Sample script to test replay concurrency safety #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
Mesa DescriptionOverviewNoticed some issues with our replay stop + download flow. Adding a script to help with testing scenarios / repeatability. I ran the docker container locally and then hit it directly. Even on local we can reasonably repro the failures TestingRan locally and confirmed we can detect the failures. Example run: What changed?
Description generated by Mesa. Update settings |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
hiroTamada
approved these changes
Dec 6, 2025
Sayan-
deleted the
sayan/kernel-633-replay-stop-concurrency-issues-lead-to-empty-videos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Noticed some issues with our replay stop + download flow. Adding a script to help with testing scenarios / repeatability.
I ran the docker container locally and then hit it directly. Even on local we can reasonably repro the failures
Testing
Ran locally and confirmed we can detect the failures. Example run:
Note
Introduce a Go script to test concurrent recording stop behavior, add retry dependency, and ignore local recordings.
server/scripts/concurrent_stop_test/main.goto reproduce and validate concurrent recordingstopbehavior (start, concurrent stop calls, retrying download, ffprobe validation, cleanup; configurable via flags).github.com/avast/retry-go/v5(updatedgo.mod/go.sum).recordings/in.gitignore.Written by Cursor Bugbot for commit 7808c6c. This will update automatically on new commits. Configure here.