Implement replay server #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgarcia
reviewed
Jun 27, 2025
Contributor
rgarcia
left a comment
rgarcia
left a comment
There was a problem hiding this comment.
this is great. I have zero comments to add after reading through it!
I assume next step is figuring out how to incorporate a compiled binary of the server onto our docker / unikernel images?
Contributor
Author
|
Yep! I wanted to separate out the meat of implementation from bundling into the images! |
rgarcia
approved these changes
Jun 27, 2025
Sayan-
added a commit
that referenced
this pull request
Jul 1, 2025
### Description In #17 we built a new API server. In this PR we integrate it into the container + unikernel image builds. It's off by default and can be turned + configured with env vars ### Testing - [x] Built docker container - [x] Ran docker container locally without the server - [x] Ran docker container locally with `WITH_KERNEL_IMAGES_API=true`. Confirmed the server started up and was able to perform the basic start, stop, down workflow successfully - [x] Built unikernel container - [x] Ran unikernel in the cloud without the server - [x] Ran unikernel in the cloud with `WITH_KERNEL_IMAGES_API=true`. Confirmed the server started up and was able to perform the basic start, stop, download workflow successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to capture the screen for headful use cases. The path we chose to do this is simply:
For the moment we're encoding semantics that the server will have one "main" recording. I've implemented the rest of the backend without this restriction so it's easy to relax down the line.
Under the hood this uses
ffmpegand expects that binary to be available. In tests running in docker and unikraft cloud the behavior around pause+resume was flaky. Instead of attempting to prevent data loss / corruption I took the strategy of minimizing the damage via ffmpeg fragmentation.I setup the server using what felt like ~sane defaults. The meat of this PR is in
ffmpeg.go. I recommend reviewing this commit by commitTesting