feat: add ENABLE_READONLY_VIEW environment flag to enable a read-only view of the browser. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ENABLE_READONLY_VIEW environment flag to enable a read-only view of the browser. Remove control buttons including input requests and the pause button.
Apply upstream patch from m1k1o/neko@b714663 to resolve issue with implicit hosting behavior. Credit to @m1k1o for the original fix.
xonkernel
changed the title
Contributor
|
@xonkernel I like the flag, but it's a little weird from a user experience perspective because it overrides the write toggle button (if you have ENABLE_READONLY_VIEW=true, the toggle toggles but doesn't actually change the setting, from my testing?). Would it be possible to hide the toggle altogether? Then it's just controlled at start-up. |
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 0d2d48f...ebc754e
5 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ENABLE_READONLY_VIEWenvironment flag to enable a read-only view of the browser.Remove control buttons including input requests and the pause button.
Move some neko cli flags to yaml config file.