clean up live view #34

rgarcia · 2025-07-14T21:57:59Z

live view has much more chill now:

no bookmark bar
no fullscreen, resolution, or pip controls
no "connected" toast
no sound
ability to set resolution and frame rate with query params e.g. w=1024&h=1336&fr=60
ability to make the live view read-only (i.e. no mouse or keyboard input) with readOnly=true

Other nice things:

set up dbus so no more log spam
get rid of no-sandbox warning

recommend reviewing commit by commit or just ignoring everything in user-data/. In order to load custom preferences had to grab the default user-data directory that chromium creates and modify it / load it onto the image

- cleared out all bookmarks in the bookmark bar - disabled the bookmark bar in Preferences

images/chromium-headful/client/src/app.vue

…nt-end-control

Sayan-

Lotta wins in this! None of my comments are blocking.

Confirming I didn't review user-data

Sayan- · 2025-07-16T00:34:09Z

images/chromium-headful/run-unikernel.sh

+name=chromium-headful-test
+
+# Name for the Kraft Cloud volume that will carry Chromium flags
+volume_name="${name}-flags"


nit - the mix of upper and lower case vars is a little confusing

I think the convention that lives in my head is: lowercase for local vars, UPPERCASE for things related to env vars

not super consistent but can nudge things in that direction

Sayan- · 2025-07-16T00:35:37Z

images/chromium-headful/run-unikernel.sh

+# Re-create the volume from scratch every run
+kraft cloud volume rm "$volume_name" || true
+kraft cloud volume create -n "$volume_name" -s 16M
+# Import the flags directory into the freshly created volume
+kraft cloud volume import -s "$FLAGS_DIR" -v "$volume_name"


do volume names need to be unique? mainly concerned about stepping on each others toes

yeah... tricky part is ensuring we delete the previously-created volume (e.g. not sure how to kraft cloud volume rm "$volume_name" || true if we make volume name unique on every run)

yeah really good point - honestly this is where I usually just toss $USER in but that's not necessarily desirable 😅

images/chromium-headful/run-unikernel.sh

Sayan- · 2025-07-16T00:42:13Z

server/cmd/api/api/computer.go

+	oapi "github.com/onkernel/kernel-images/server/lib/oapi"
+)
+
+func (s *ApiService) MoveMouse(ctx context.Context, request oapi.MoveMouseRequestObject) (oapi.MoveMouseResponseObject, error) {


non-blocking. there is a local dev flow for the server. since xdotool isn't supported on macos we may want to detect and return a 501 instead

my local dev flow was building / running the docker image and curl'ing this endpoint... wasn't too bad

on mac os we might be able to do this with applescript

as always things get complicated going from docker -> unikraft - disable scale to zero - add a sleep because this makes it work

Sayan- · 2025-07-16T15:16:07Z

images/chromium-headful/wrapper.sh

+      # wait... not sure but this just increases the likelihood of success
+      sleep 5


what were the failure modes you were running into?

without the sleep I'd often open the live view and see the mouse hovering over the "X" to dismiss the warning, suggesting that xdotool did it's thing before the warning or chromium appeared

will add to the comment describing this

Sayan- · 2025-07-16T15:17:25Z

images/chromium-headful/wrapper.sh

+      echo "Waiting for kernel-images API port 127.0.0.1:10001..."
+      while ! nc -z 127.0.0.1 10001 2>/dev/null; do


potential optimization: I'd expect the server to come up faster than chromium so we could probably trim some time by inverting the order

Sayan- · 2025-07-16T15:20:36Z

images/chromium-headful/build-unikernel.sh


 kraft pkg \
-  --name index.unikraft.io/$image \
+  --name $UKC_INDEX/$IMAGE \


should we default to the public unikraft index to make this easier for folks?

rgarcia added 7 commits July 14, 2025 14:49

set up / run as unpriviliged 'kernel' user; fix dbus

12ba047

get rid of no-sandbox warning, run on 8080 in the foreground

601ce91

disable sound

5dbd4a5

disable "connected" notification

f4cb6bf

disable fullscreen, resolution, and pip controls

33422c6

don't show upper / lower control sections that had tons of padding

25f40bd

default user data with some modifications:

a084937

- cleared out all bookmarks in the bookmark bar - disabled the bookmark bar in Preferences

rgarcia requested a review from heyglassy July 14, 2025 21:58

This comment was marked as outdated.

Sign in to view

✨ resolution and frame rate control ✨

1dce3cb

This comment was marked as outdated.

Sign in to view

rgarcia added 3 commits July 14, 2025 15:09

kill dbus daemon

67ac460

denote our mods

7593289

add read only flag

cd4c5ca

Sayan- reviewed Jul 14, 2025

View reviewed changes

images/chromium-headful/client/src/app.vue Show resolved Hide resolved

heyglassy reviewed Jul 14, 2025

View reviewed changes

images/chromium-headful/client/src/app.vue Outdated Show resolved Hide resolved

heyglassy approved these changes Jul 14, 2025

View reviewed changes

rgarcia and others added 2 commits July 14, 2025 17:29

test for w/h/fr NaN in one place

a3be73a

unikernel tweaks for running as kernel user

f32b8f0

This comment was marked as outdated.

Sign in to view

ok cursor

5aaa6fe

This comment was marked as outdated.

Sign in to view

might have to click the mouse...

43d739d

rgarcia force-pushed the raf/kernel-167-remove-picture-in-picture-front-end-control branch from 6562d59 to 43d739d Compare July 15, 2025 21:55

clickity clack

59b1c73

This comment was marked as outdated.

Sign in to view

rgarcia added 2 commits July 15, 2025 16:56

h/t my boi cursor

59b95b7

Merge branch 'main' into raf/kernel-167-remove-picture-in-picture-fro…

ea50fcb

…nt-end-control

This comment was marked as outdated.

Sign in to view

only set --no-sandbox --no-zygote if running as root

82eceb9

default run as root false in docker, true in ukc

5615029

This comment was marked as outdated.

Sign in to view

echo correct

89ef11c

Sayan- approved these changes Jul 16, 2025

View reviewed changes

rgarcia added 2 commits July 15, 2025 17:56

address pr comments

dff5ee3

use volimport from onkernel user

7eaf7ae

This comment was marked as outdated.

Sign in to view

Sayan- approved these changes Jul 16, 2025

View reviewed changes

wait for chromium window to appear before clicking

fef4102

This comment was marked as outdated.

Sign in to view

i didn't choose the unikernel life, it chose me

59bbc8b

as always things get complicated going from docker -> unikraft - disable scale to zero - add a sleep because this makes it work

Sayan- approved these changes Jul 16, 2025

View reviewed changes

pr feedback

7b95731

Sayan- approved these changes Jul 16, 2025

View reviewed changes

rgarcia merged commit ae8724a into main Jul 16, 2025
2 checks passed

rgarcia deleted the raf/kernel-167-remove-picture-in-picture-front-end-control branch July 16, 2025 20:07

		# wait... not sure but this just increases the likelihood of success
		sleep 5

		echo "Waiting for kernel-images API port 127.0.0.1:10001..."
		while ! nc -z 127.0.0.1 10001 2>/dev/null; do

clean up live view #34

clean up live view #34

Uh oh!

Conversation

rgarcia commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Sayan- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rgarcia commented Jul 14, 2025 •

edited

Loading