Skip to content

Conversation

@rgarcia
Copy link
Contributor

@rgarcia rgarcia commented Jul 23, 2025

image

link


TL;DR

Enhanced uk-check-stats.sh to display new network-related instance metrics.

Why we made these changes

To provide more comprehensive insights into instance performance, specifically network connection and request statistics, which are crucial for monitoring and debugging.

What changed?

  • shared/uk-check-stats.sh: Updated to collect and display instance_nconns, instance_nreqs, instance_nqueued, and instance_ntotal metrics. The script's output header and data display were adjusted to incorporate these new columns.

Validation

  • Verified script output includes the new network statistics as shown in the PR body image.

@rgarcia rgarcia requested a review from Sayan- July 23, 2025 21:17
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Changed

This PR enhances the uk-check-stats.sh script to include additional network-related metrics. The script's output now includes 'NConns', 'NReqs', 'NQueued', and 'NTotal', providing a more comprehensive view of instance performance alongside the existing CPU and memory stats.

Risks / Concerns

The changes are straightforward and well-contained within the script. The implementation looks solid. Great work on enhancing the observability of our instances!

1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

@rgarcia rgarcia requested a review from heyglassy July 23, 2025 21:18
@rgarcia rgarcia merged commit 1a13f21 into main Jul 23, 2025
3 checks passed
@rgarcia rgarcia deleted the script-tweaks branch July 23, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants