Live view disconnections fix (v1) #45
Closed
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia event.CHAT_MESSAGE
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| this.sendMessage(EVENT.CLIENT.HEARTBEAT) | ||
| this.emit('debug', `sending chat/message`) | ||
| this.sendMessage(EVENT.CHAT.MESSAGE, { content: `heartbeat/fake [${Date.now()}]` }) | ||
| }, heartbeat_interval * 1000) |
There was a problem hiding this comment.
Bug: Heartbeat Messages Flood Chat Interface
The heartbeat mechanism sends fake chat messages with content "heartbeat/fake [timestamp]" to the chat interface every heartbeat interval. These technical messages, intended for connection keep-alive, spam the chat and degrade the user experience.
Merged
rgarcia
reviewed
Aug 4, 2025
| this.emit('debug', `sending client/heartbeat`) | ||
| this.sendMessage(EVENT.CLIENT.HEARTBEAT) | ||
| this.emit('debug', `sending chat/message`) | ||
| this.sendMessage(EVENT.CHAT.MESSAGE, { content: `heartbeat/fake [${Date.now()}]` }) |
Contributor
There was a problem hiding this comment.
@raiden-staging what's the purpose of this chat message event? If the heartbeat is getting a response now is that sufficient or is this chat message required too?
Contributor
|
Merged in with #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue #27]
Analysis
event.CLIENT_HEARTBEATin websockets handlerevent.MEMBER_CONNECT&event.MEMBER_DISCONNECTto the client every few seconds to keepalive. seems to work :)kernel_debug_peer.mp4
both sessions have steady input.
left session has peer disconnect error 3x in the recorded interval.
right session, where neko sends new event to client every few secs (member notifications), has no peer disconnect error in the interval.
Fix
neko/chromium:3.0.6-kernel-v1.1) sets a reduced heartbeat interval.neko.yaml, sending dummyevent.CHAT_MESSAGEalongsideevent.CLIENT_HEARTBEATfrom client, as neko handler replies to the event.event.SYSTEM_HEARTBEATin the neko src, will use it instead of theevent.CHAT_MESSAGEworkaround later if the approach works when deployed)this could fix live view peer disconnections.
Notes
UKC_TOKENhas <8gb required memory quotas.