Skip to content

Conversation

@hiroTamada
Copy link
Contributor

@hiroTamada hiroTamada commented Oct 24, 2025

  • Disabling both password and card save popup
  • Adding 1200*800

Note

Disables Chrome password/credit-card save prompts and adds 1200x800 modelines across refresh rates to xorg config.

  • Configuration
    • Chromium policies: Add images/chromium-headful/image-chromium/etc/chromium/policies/managed/autofill.json with PasswordManagerEnabled: false and AutofillCreditCardEnabled: false.
  • Display
    • Xorg: In images/chromium-headful/xorg.conf, add 1200x800 modelines for 60/30/25/10 Hz and include them in the Screen Modes list.

Written by Cursor Bugbot for commit 68a0120. This will update automatically on new commits. Configure here.

@hiroTamada hiroTamada requested a review from rgarcia October 24, 2025 19:13
@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Oct 24, 2025

Mesa Description

  • Disabling both password and card save popup
  • Adding 1200*800

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 174e365...68a0120

Analysis

  1. The autofill policy implementation only addresses password and credit card popups, but lacks comprehensive popup blocking (missing DefaultPopupsSetting, DefaultNotificationsSetting, and PromptForDownloadLocation policies).

  2. The added 1200x800 resolution uses a 3:2 aspect ratio that is uncommon by modern display standards, potentially causing compatibility or user experience issues compared to more standard options (16:9, 16:10, or 5:4 ratios).

  3. While both changes follow established patterns and are low-risk, the PR title "Disable Popup" suggests a more comprehensive popup blocking solution than what's actually implemented.

Tip

Help

Configure your agents

Mesa Docs

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

2 files reviewed | 0 comments | Edit Agent Settings

@hiroTamada hiroTamada merged commit a653a87 into main Oct 24, 2025
7 checks passed
@hiroTamada hiroTamada deleted the hiro/disable_pop_up branch October 24, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants