Skip to content

Conversation

@hiroTamada
Copy link
Contributor

@hiroTamada hiroTamada commented Oct 28, 2025

Checklist

  • A link to a related issue in our repository
  • A description of the changes proposed in the pull request.
  • @mentions of the person or team responsible for reviewing proposed changes.

Note

Set the default viewport to 1920x1080 (25Hz where applicable) across headful/headless images, configs, and run scripts.

  • Headful:
    • images/chromium-headful/Dockerfile: Set ENV HEIGHT=1080 and ENV WIDTH=1920.
    • images/chromium-headful/neko.yaml: Update desktop screen to "1920x1080@25".
    • images/chromium-headful/run-docker.sh and run-unikernel.sh: Pass HEIGHT=1080 and WIDTH=1920 to the container/instance.
  • Headless:
    • images/chromium-headless/image/start-xvfb.sh: Default WIDTH=1920, HEIGHT=1080.
    • images/chromium-headless/image/wrapper.sh: Export defaults HEIGHT=1080, WIDTH=1920.

Written by Cursor Bugbot for commit 593f8e5. This will update automatically on new commits. Configure here.

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Oct 28, 2025

Mesa Description

Checklist

  • A link to a related issue in our repository
  • A description of the changes proposed in the pull request.

This PR changes the default viewport to 1920x1080@25.

  • @mentions of the person or team responsible for reviewing proposed changes.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 6d144ca...593f8e5

Analysis

  1. Inconsistent refresh rate change from 60Hz to 25Hz across configuration files, which lacks clear justification and may negatively impact user experience
  2. The significant resolution increase (1024x768 to 1920x1080) may have performance implications on resource-constrained systems that are not addressed
  3. While environment variables are used to centralize resolution settings, there's no evidence of backward compatibility considerations for systems already deployed with the previous configuration

Tip

Help

Configure your agents

Mesa Docs

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

6 files reviewed | 0 comments | Edit Agent Settings

Copy link
Contributor

@Sayan- Sayan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esp if neko is the one dictating this do we need to set the env vars? lgtm otherwise ^^

edit: nvm headless

@hiroTamada
Copy link
Contributor Author

esp if neko is the one dictating this do we need to set the env vars? lgtm otherwise ^^

edit: nvm headless

we dont. But technically, you can override through the env I think. So I just kept it as an example.

@hiroTamada hiroTamada merged commit 8248caf into main Oct 28, 2025
9 of 10 checks passed
@hiroTamada hiroTamada deleted the hiro/change_default_viewport branch October 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants