Merge pull request #2 from raiden-staging/master

Keepalive fix cleanup [neko]

Author: rgarcia

server/internal/http/legacy/event/events.go

@@ -4,6 +4,8 @@ const (
 	SYSTEM_INIT       = "system/init"
 	SYSTEM_DISCONNECT = "system/disconnect"
 	SYSTEM_ERROR      = "system/error"
+	SYSTEM_HEARTBEAT  = "system/heartbeat"
+	SYSTEM_PONG       = "system/pong"
 )
 
 const (

server/internal/http/legacy/message/messages.go

@@ -24,6 +24,11 @@ type SystemMessage struct {
 	Message string `json:"message"`
 }
 
+type SystemPong struct {
+	Event     string `json:"event"`
+	Timestamp string `json:"timestamp"`
+}
+
 type SignalProvide struct {
 	Event string             `json:"event"`
 	ID    string             `json:"id"`

server/internal/http/legacy/wstobackend.go

@@ -4,7 +4,9 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
-
+	"strconv"
+	"time"
+	
 	"github.com/pion/webrtc/v3"
 
 	oldEvent "github.com/m1k1o/neko/server/internal/http/legacy/event"
@@ -28,8 +30,10 @@ func (s *session) wsToBackend(msg []byte) error {
 	switch header.Event {
 	// Client Events
 	case oldEvent.CLIENT_HEARTBEAT:
-		// do nothing
-		return nil
+		return s.toClient(&oldMessage.SystemPong{
+			Event:     oldEvent.SYSTEM_PONG,
+			Timestamp: strconv.FormatInt(time.Now().UnixMilli(), 10),
+		})
 
 	// Signal Events
 	case oldEvent.SIGNAL_OFFER:

server/internal/websocket/handler/handler.go

@@ -1,7 +1,6 @@
 package handler
 
 import (
-	"time"
 	"github.com/rs/zerolog"
 	"github.com/rs/zerolog/log"
 
@@ -39,9 +38,7 @@ func (h *MessageHandlerCtx) Message(session types.Session, data types.WebSocketM
 	switch data.Event {
 	// Client Events
 	case event.CLIENT_HEARTBEAT:
-		session.Send("system/heartbeat", map[string]any{
-			"timestamp": time.Now(),
-		})
+		err = h.systemPong(session)
 
 	// System Events
 	case event.SYSTEM_LOGS:
@@ -196,6 +193,7 @@ func (h *MessageHandlerCtx) Message(session types.Session, data types.WebSocketM
 			return h.sendBroadcast(session, payload)
 		})
 	default:
+		err = h.systemPong(session)
 		return false
 	}
 

server/internal/websocket/handler/system.go

@@ -1,6 +1,7 @@
 package handler
 
 import (
+	"time"
 	"github.com/rs/zerolog"
 	"github.com/rs/zerolog/log"
 
@@ -94,3 +95,13 @@ func (h *MessageHandlerCtx) systemLogs(session types.Session, payload *message.S
 
 	return nil
 }
+
+func (h *MessageHandlerCtx) systemPong(session types.Session) error {
+	session.Send(
+		event.SYSTEM_PONG,
+		message.SystemPong{
+			Timestamp: time.Now().UnixMilli(),
+		},
+	)
+	return nil
+}

server/internal/websocket/manager.go

@@ -32,8 +32,8 @@ var nologEvents = []string{
 	// don't log twice
 	event.SYSTEM_LOGS,
 	// don't log heartbeats
-	event.SYSTEM_HEARTBEAT,
-	event.CLIENT_HEARTBEAT,
+	// event.CLIENT_HEARTBEAT,
+	// event.SYSTEM_PONG,
 	// don't log every cursor update
 	event.SESSION_CURSORS,
 }

server/pkg/types/event/events.go

@@ -7,6 +7,7 @@ const (
 	SYSTEM_LOGS       = "system/logs"
 	SYSTEM_DISCONNECT = "system/disconnect"
 	SYSTEM_HEARTBEAT  = "system/heartbeat"
+	SYSTEM_PONG       = "system/pong"
 )
 
 const (

server/pkg/types/message/messages.go

@@ -47,6 +47,11 @@ type SystemSettingsUpdate struct {
 	types.Settings
 }
 
+// SystemPong is sent by the server as a direct response to CLIENT_HEARTBEAT
+type SystemPong struct {
+	Timestamp int64 `json:"timestamp"` // Unix ms
+}
+
 /////////////////////////////
 // Signal
 /////////////////////////////