Skip to content

Commit 3fe1aef

Browse files
committed
Removed deprecated size and change connection security protocol
1 parent b60a7d4 commit 3fe1aef

File tree

3 files changed

+11
-25
lines changed

3 files changed

+11
-25
lines changed

src/Statement/CreateConnection.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,14 @@ private function __construct(string $name, string $definition)
4242
public static function kafka(string $name, string ...$brokers): self
4343
{
4444
if (count($brokers) > 1) {
45-
$definition = sprintf('KAFKA (BROKERS (%s))', implode(', ', array_map(static function (string $dsn) {
46-
return sprintf('\'%s\'', $dsn);
47-
}, $brokers)));
45+
$definition = sprintf(
46+
'KAFKA (BROKERS (%s), SECURITY PROTOCOL = \'PLAINTEXT\')',
47+
implode(', ', array_map(static function (string $dsn) {
48+
return sprintf('\'%s\'', $dsn);
49+
}, $brokers))
50+
);
4851
} else {
49-
$definition = sprintf('KAFKA (BROKER \'%s\')', current($brokers));
52+
$definition = sprintf('KAFKA (BROKER \'%s\', SECURITY PROTOCOL = \'PLAINTEXT\')', current($brokers));
5053
}
5154

5255
return new self($name, $definition);

src/Statement/CreateSink.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ public function __toString(): string
109109
$query .= ' IF NOT EXISTS';
110110
}
111111

112-
$query .= ' %s FROM %s INTO %s WITH (SIZE = \'%s\')';
112+
$query .= ' %s FROM %s INTO %s';
113113

114-
return sprintf($query, $this->name, $this->from, $this->definition, $this->size);
114+
return sprintf($query, $this->name, $this->from, $this->definition);
115115
}
116116
}

src/Statement/CreateSource.php

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ class CreateSource implements Command
1919
*/
2020
private $definition;
2121

22-
/**
23-
* @var string
24-
*/
25-
private $size = '1';
26-
2722
/**
2823
* @var bool
2924
*/
@@ -71,18 +66,6 @@ public static function postgres(string $name, string $connection, string $public
7166
return new self($name, $definition);
7267
}
7368

74-
/**
75-
* @param string $size
76-
*
77-
* @return self
78-
*/
79-
public function size(string $size): self
80-
{
81-
$this->size = $size;
82-
83-
return $this;
84-
}
85-
8669
/**
8770
* @return self
8871
*/
@@ -106,8 +89,8 @@ public function __toString(): string
10689
$query .= ' IF NOT EXISTS';
10790
}
10891

109-
$query .= ' %s FROM %s WITH (SIZE = \'%s\')';
92+
$query .= ' %s FROM %s';
11093

111-
return sprintf($query, $this->name, $this->definition, $this->size);
94+
return sprintf($query, $this->name, $this->definition);
11295
}
11396
}

0 commit comments

Comments
 (0)