Skip to content

BrowserConfig Interface - Incorrect Required Property #49

@matdombrock

Description

@matdombrock

The BrowserConfig interface requires type but I don't think that's really meant to be required. The README says that all options are optional.

type : string

This should be changed to:

export interface BrowserConfig {
    type?        : string // now optional
    name?       : string
    protocol?   : 'tcp' | 'udp'
    subtypes?   : string[]
    txt?        : KeyValue
}

Making this change myself gives me the expected behavior, which is looking for all service types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions