event `error` from Service never emitted

[vb-linetco]

According to the documentation the Service emits an event named "error" in case of errors but it never does, it only logs the one possible error where the service name collides with another service in the network.

bonjour-service/src/lib/registry.ts

Line 35 in 30abed0

console.log(new Error('Service name is already in use on the network'))

The original implementation did emit an error in that case, see here:
https://github.com/watson/bonjour/blob/bdc467a4f3c7b9fe8bc54468b6fc4d80b8f1c098/lib/registry.js#L47

So whenever an error occurs, due to name collisions, a consumer cannot detect it using the API.

Is that behavior intended?

[vb-linetco]

One can reproduce this using the following script

import { Bonjour } from "bonjour-service";

const instance = new Bonjour();

const service = instance.publish({
  name: "MyService",
  type: "http",
  port: 3000,
  host: "my-hostname.local",
});

service.on("up", () => {
  console.log(service, "is up");
});

service.on("error", (err) => {
  console.error("Failed to publish", err);
});

by running it twice, the second instance will never log an error with "Failed to publish", one can only see the internally logged error.