Skip to content

Commit 4944dd2

Browse files
committed
review feedback
1 parent 11c7e39 commit 4944dd2

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tf2onnx/tfonnx.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,8 @@ def reduce_op(ctx, node, name, args):
255255
axes = [axes]
256256
input_shape = ctx.get_shape(node.input[0])
257257
if input_shape is None:
258-
for val in axes:
259-
if val < 0:
260-
raise ValueError("reduce_op: can have negative axis because we don't know input rank")
258+
if any([val < 0 for val in axes]):
259+
raise ValueError("reduce_op: cannot have negative axis because we don't know input rank")
261260
else:
262261
input_rank = len(ctx.get_shape(node.input[0]))
263262
axes = [val + input_rank if val < 0 else val for val in axes]

0 commit comments

Comments
 (0)