Skip to content

Commit 603da0a

Browse files
committed
refactor according to code review
1 parent 6ce2eb9 commit 603da0a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tf2onnx/optimizer/transpose_optimizer.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Copyright (c) Microsoft Corporation. All rights reserved.
22
# Licensed under the MIT license.
3+
34
"""Transpose Optimizer."""
45

56
from __future__ import unicode_literals
@@ -114,9 +115,9 @@ def post_optimize_action(self):
114115
self._g.update_proto()
115116
self._g.topological_sort(self._g.get_nodes())
116117

117-
def merge_transpose_with_same_input(self):
118+
def merge_duplicated_transposes(self):
118119
# strategy used in previous procedure is to move transpose nodes down if possible,
119-
# and it means that when a node has n outputs then n transpose will be generated ,
120+
# and it means that when a node has n outputs then n transpose will be generated,
120121
# so we should merge them back to one if they can't be eliminated in previous procedure.
121122
graph = self._g
122123
input_transposes_map = defaultdict(list)
@@ -125,7 +126,7 @@ def merge_transpose_with_same_input(self):
125126
key = (node.input[0], str(node.get_attr("perm").ints))
126127
input_transposes_map[key].append(node)
127128

128-
for _, transposes in input_transposes_map.items():
129+
for transposes in input_transposes_map.values():
129130
# merge transpose nodes into one: make nodes use the output of the first transpose node
130131
transpose_out = transposes[0].output[0]
131132
for node in transposes[1:]:
@@ -163,8 +164,8 @@ def optimize(self):
163164

164165
log.debug("finish after " + str(iteration_cnt) + " iteration(s)")
165166

167+
self.merge_duplicated_transposes()
166168
self.post_optimize_action()
167-
self.merge_transpose_with_same_input()
168169

169170
current_counter = self._g.dump_node_statistics()
170171
transpose_cnt = current_counter["Transpose"]

0 commit comments

Comments
 (0)