Skip to content

Commit 9f0e385

Browse files
author
wayuanho
committed
add comments
1 parent f2377c4 commit 9f0e385

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

tf2onnx/tfonnx.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2477,7 +2477,9 @@ def topological_sort(g, continue_on_error):
24772477

24782478
def run_rewriters(g, funcs, continue_on_error):
24792479
"""Rewrite the original graph and body graphs of nodes"""
2480-
# NOTE: not topologically sort graph here
2480+
# NOTE(wayuanho):
2481+
# 1. we don't sort graph here, rewriter is expected to do it on its own.
2482+
# 2. the graph here may have circles, current topological_sort cannot handle it.
24812483
for func in funcs:
24822484
try:
24832485
ops = func(g, g.get_nodes())

0 commit comments

Comments
 (0)