Merge pull request #617 from lucienwang1009/check_shape

check shape for unittests

Author: zhijxu-MS

tests/backend_test_base.py

@@ -75,7 +75,7 @@ def run_backend(self, g, outputs, input_dict):
         return y
 
     def run_test_case(self, feed_dict, input_names_with_port, output_names_with_port, rtol=1e-07, atol=1e-5,
-                      convert_var_to_const=True, constant_fold=True, check_value=True, check_shape=False,
+                      convert_var_to_const=True, constant_fold=True, check_value=True, check_shape=True,
                       check_dtype=True, process_args=None, onnx_feed_dict=None, graph_validator=None):
         # optional - passed to process_tf_graph
         if process_args is None:
@@ -131,6 +131,8 @@ def run_test_case(self, feed_dict, input_names_with_port, output_names_with_port
                 self.assertAllClose(expected_val, actual_val, rtol=rtol, atol=atol)
             if check_dtype:
                 self.assertEqual(expected_val.dtype, actual_val.dtype)
+            # why need shape checke: issue when compare [] with scalar
+            # https://github.com/numpy/numpy/issues/11071
             if check_shape:
                 self.assertEqual(expected_val.shape, actual_val.shape)
 

tests/test_backend.py

@@ -1167,15 +1167,14 @@ def _test_range_non_const(self, extra_opset=None):
                         or check_node_domain(group_nodes_by_type(g)["Range"][0], extra_opset.domain))
         tf.reset_default_graph()
 
-        # disable this case for ms domain due to onnxruntime range-1 issue
-        # https://github.com/Microsoft/onnxruntime/issues/730
-        if not (extra_opset and extra_opset.domain == constants.MICROSOFT_DOMAIN):
-            x = tf.range(3.0, 3.0, 5)
-            _ = tf.identity(x, name=_TFOUTPUT)
-            g = self._run_test_case([_OUTPUT], {}, process_args=process_args)
-            self.assertTrue(extra_opset is None
-                            or check_node_domain(group_nodes_by_type(g)["Range"][0], extra_opset.domain))
-            tf.reset_default_graph()
+        # disable this case due to onnxruntime loop issue
+        # https://github.com/microsoft/onnxruntime/issues/1272
+        # x = tf.range(3.0, 3.0, 5)
+        # _ = tf.identity(x, name=_TFOUTPUT)
+        # g = self._run_test_case([_OUTPUT], {}, process_args=process_args)
+        # self.assertTrue(extra_opset is None
+        #                 or check_node_domain(group_nodes_by_type(g)["Range"][0], extra_opset.domain))
+        # tf.reset_default_graph()
 
         delta_val = np.array(1.5, dtype=np.float32)
         delta = tf.placeholder(tf.float32, shape=(), name=_TFINPUT)