Skip to content

Commit f13d8b6

Browse files
committed
fix pylint
1 parent 67efaa5 commit f13d8b6

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

tests/test_optimizers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,8 @@ def test_duplicated_node_is_graph_output(self):
348348
)
349349

350350
model_proto = helper.make_model(graph, producer_name="onnx-tests")
351-
self.run_merge_duplicated_nodes_compare(["value1", "value2"], {"X": np.random.randn(5, 5).astype(np.float32)}, model_proto,
351+
self.run_merge_duplicated_nodes_compare(["value1", "value2"],
352+
{"X": np.random.randn(5, 5).astype(np.float32)}, model_proto,
352353
op_type="Add", remaining_op_num=2)
353354

354355
def test_duplicated_different_output_length(self):

tf2onnx/optimizer/identity_optimizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
log = logging.getLogger("tf2onnx.optimizer.identity_optimizer")
1515

1616

17-
# pylint: disable=logging-not-lazy,unused-argument,missing-docstring,unused-variable
17+
# pylint: disable=logging-not-lazy,unused-argument,missing-docstring,unused-variable,arguments-differ
1818

1919

2020
class IdentityOptimizer(GraphOptimizerBase):

tf2onnx/optimizer/merge_duplicated_nodes_optimizer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@
1515

1616
# pylint: disable=logging-not-lazy,unused-argument,missing-docstring
1717

18+
_KeyToGroupNodes = namedtuple("key", "type input")
1819

1920
class MergeDuplicatedNodesOptimizer(GraphOptimizerBase):
2021
"""Remove duplicate nodes.
2122
"""
22-
_KeyToGroupNodes = namedtuple("key", "type input")
23-
2423
def __init__(self, debug=False):
2524
super(MergeDuplicatedNodesOptimizer, self).__init__(debug)
2625
# optimizer should have name and log property
@@ -47,10 +46,11 @@ def _merge_duplicated_nodes(self, graph):
4746
continue
4847
self._del_nodes_if_duplicated(nodes_group, graph)
4948

50-
def _group_nodes_by_type_inputs(self, graph):
49+
@staticmethod
50+
def _group_nodes_by_type_inputs(graph):
5151
res = defaultdict(list)
5252
for node in graph.get_nodes():
53-
res[self._KeyToGroupNodes(node.type, tuple(node.input))].append(node)
53+
res[_KeyToGroupNodes(node.type, tuple(node.input))].append(node)
5454
return res
5555

5656
def _del_nodes_if_duplicated(self, nodes_group, graph):

tf2onnx/optimizer/transpose_optimizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
log = logging.getLogger("tf2onnx.optimizer.transpose_optimizer")
1818

1919

20-
# pylint: disable=logging-not-lazy,unused-argument,missing-docstring
20+
# pylint: disable=logging-not-lazy,unused-argument,missing-docstring,abstract-method
2121
# FIXME:
2222
# pylint: disable=unused-variable
2323

0 commit comments

Comments
 (0)