Passing custom headers through send-chat-message API is not working

[mydnic]

Following this PR : #7390

I updated my onyx (docker) to 2.10 in order to test this, and it didn't work.

Current version : 2.10.3

I've added the MCP server, it works and list the tools

I've given access to the custom Assistant.

When testing inside Onyx Web Ui, the assistant is able to use the MCP and gather my data

But when using as an API, it does not.

First i create a chat session and specify the assistant i want :

// api/chat/create-chat-session

{
    "persona_id": 1,
    "description": null,
    "project_id": null
}

then ask something that should trigger a request to my mcp server:

{
    "message": "how many unpaid invoices i have ?",
    "chat_session_id": "f875c31b-4582-4da5-8e26-61cdadfcbfc3",
    "parent_message_id": -1,
    "stream": false,
    "mcp_headers": {
        "Authorization": "Bearer MY_APP_JWT",
        "X-Creche-UUID": "UUID"
    }
}

also tried this, same result (matching variable names in Onyx UI)

{
    "message": "how many unpaid invoices i have ?",
    "chat_session_id": "f875c31b-4582-4da5-8e26-61cdadfcbfc3",
    "parent_message_id": -1,
    "stream": false,
    "mcp_headers": {
        "api_key": "MY_APP_JWT",
        "creche_uuid": "UUID"
    }
}

What I get in result is basically "you're not authenticated to that mcp server, please authenticate"

I also notice that my MCP server is not receiving any request, so it's like Onyx/the assistant thinks he doesn't have the necessary keys to use the mcp ?

Here are some screenshots

[mydnic]

I believe this is the cause : https://github.com/onyx-dot-app/onyx/blob/main/backend/onyx/tools/tool_implementations/mcp/mcp_tool.py#L162

I edited the code locally to this

            has_auth_config = (
                (self.connection_config is not None and bool(headers))
                or bool(self._additional_headers)  # API-provided headers count as valid auth
            ) or (is_passthrough_oauth and self._user_oauth_token is not None)

then I rebuild with docker compose build api_server && docker compose up -d api_server

then I tried the API, now it works ! the assistant is able to use our MCP server

[evan-onyx]

Thanks for finding this @mydnic ! I believe we should be enforcing the connection config existence though? Something like

has_auth_config = (
                (self.connection_config is not None and (bool(headers)
                or bool(self._additional_headers))  # API-provided headers count as valid auth
            ) or (is_passthrough_oauth and self._user_oauth_token is not None)

[mydnic]

Thanks for finding this @mydnic ! I believe we should be enforcing the connection config existence though? Something like

has_auth_config = (
                (self.connection_config is not None and (bool(headers)
                or bool(self._additional_headers))  # API-provided headers count as valid auth
            ) or (is_passthrough_oauth and self._user_oauth_token is not None)

maybe i'm going blind but i don't see the difference between the two block code lol