Re: Added some features (mainly Android)#50
Merged
hatch01 merged 3 commits intoonyx-lyon1:devfrom Oct 18, 2025
Merged
Conversation
hatch01
requested changes
Oct 15, 2025
Member
hatch01
left a comment
There was a problem hiding this comment.
The first review mainly focused on the dart side.
I still want to improve the serializer, which is probably possible to completely drop.
Will look at the Kotlin part later.
apps/onyx/lib/screens/agenda_config/page/agenda_config_page.dart
Outdated
Show resolved
Hide resolved
apps/onyx/lib/screens/agenda_config/page/agenda_config_page.dart
Outdated
Show resolved
Hide resolved
apps/onyx/lib/screens/agenda_config/page/agenda_config_page.dart
Outdated
Show resolved
Hide resolved
apps/onyx/lib/screens/agenda_config/page/agenda_config_page.dart
Outdated
Show resolved
Hide resolved
hatch01
reviewed
Oct 15, 2025
hatch01
reviewed
Oct 15, 2025
hatch01
reviewed
Oct 15, 2025
TimEtOff
added a commit
to TimEtOff/onyx
that referenced
this pull request
Oct 15, 2025
hatch01
pushed a commit
to TimEtOff/onyx
that referenced
this pull request
Oct 16, 2025
Member
|
Just FYI, I force-pushed to split your commit in a more atomic way. |
hatch01
requested changes
Oct 16, 2025
TimEtOff
added a commit
to TimEtOff/onyx
that referenced
this pull request
Oct 18, 2025
Author
|
Implemented your method (I agree, it's better this way), but tweaked a few things after tests and added a Res variable to choose if we want to show empty days that are not disabled, could be a user setting for later. I'd like to note that I got a working macOS VM so I'll probably make a new PR for the iOS widget in the future (might add user settings and other small features at the same time). |
hatch01
reviewed
Oct 18, 2025
apps/onyx/android/app/src/main/java/fr/onyx/lyon1/AgendaWidget.kt
Outdated
Show resolved
Hide resolved
hatch01
reviewed
Oct 18, 2025
apps/onyx/android/app/src/main/java/fr/onyx/lyon1/AgendaWidget.kt
Outdated
Show resolved
Hide resolved
apps/onyx/android/app/src/main/java/fr/onyx/lyon1/AgendaWidget.kt
Outdated
Show resolved
Hide resolved
TimEtOff
added a commit
to TimEtOff/onyx
that referenced
this pull request
Oct 18, 2025
hatch01
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agenda Config Page:
On the Agenda Config Page, made the back button (and native back button/gesture on Android) actually go back one level in the files/agendas structure instead of closing the config page.
The page will still close if its the last level.
I couldn't test it on iOS nor Linux, but I don't think it can cause any problem, except just not working with iOS back gesture.
Preview
Homescreen widget
Added homescreen widget compatibility for the agenda with the HomeWidget flutter plugin.
Preview (light theme)
Preview (night/dark theme)