Challenge 2 4 gives bad error on Windows

[niklasjansson]

While running Challenge 2 4, the check

(is (= ["Peer executing task :identity"
              "Peer executing task :identity"
              "Peer executing task :identity"
              "Peer executing task :read-segments"
              "Peer executing task :write-segments"]
             (sort (butlast (rest results))))))))

fails. On windows, each row has an appended \r.

[lbradstreet]

Thanks for the report. We admit that we had not tested it on Windows. We'll get it fixed up soon!

On 11 Mar 2016, at 9:28 PM, niklasjansson notifications@github.com wrote:

While running Challenge 2 4, the check

(is (= ["Peer executing task :identity"
"Peer executing task :identity"
"Peer executing task :identity"
"Peer executing task :read-segments"
"Peer executing task :write-segments"](sort %28butlast %28rest results%29%29))))))
fails. On windows, each row has an appended \r.

—
Reply to this email directly or view it on GitHub.

[lbradstreet]

Challenge 2_4 also fails when the job can start and finish before three peers are assigned to :identity. This has happened on CI. I'm not sure what the best way to fix this is since we're trying to demonstrate that multiple peers started up and :identity is the task they have to define. I guess we could change the sample to say that the users should increase n-peers rather than max-peers?

[Engelberg]

Ditto on challenge 4_1. Easy fix, change the regex in split to:
(clojure.string/split output #"\r?\n")

[MichaelDrogalis]

We need to excise everywhere that does stdout checking. This really hurt us when we moved to Onyx 0.9.6 since errors are pretty printed directly to stdout. Should eliminate this issue once we do it.