Skip to content

Commit e71bc5f

Browse files
authored
chore(deps): upgrade ovm-ssh-agent to 3.0.0 (#83)
Signed-off-by: Kevin Cui <bh@bugs.cc>
1 parent 9a53bbe commit e71bc5f

File tree

3 files changed

+17
-22
lines changed

3 files changed

+17
-22
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ require (
1717
github.com/go-playground/validator/v10 v10.25.0
1818
github.com/gorilla/mux v1.8.1
1919
github.com/json-iterator/go v1.1.12
20-
github.com/oomol-lab/ovm-ssh-agent v1.1.1-0.20250319032115-b469155aff8d
20+
github.com/oomol-lab/ovm-ssh-agent/v3 v3.0.0
2121
github.com/oomol-lab/ssh-forward v0.0.0-20250319062521-6d0eb022abac
2222
github.com/prashantgupta24/mac-sleep-notifier v1.0.1
2323
github.com/shirou/gopsutil/v3 v3.24.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd h1:TRLaZ9cD/w
6464
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
6565
github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9Gz0M=
6666
github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk=
67-
github.com/oomol-lab/ovm-ssh-agent v1.1.1-0.20250319032115-b469155aff8d h1:cjVNvVjTw/G3u1mJmZs7Nbo8v6rc6RkElLYdiaHGbes=
68-
github.com/oomol-lab/ovm-ssh-agent v1.1.1-0.20250319032115-b469155aff8d/go.mod h1:UiWnuQCSmt3Zta1LctVpp+ETEaJv08OA+Bkp45uyM/M=
67+
github.com/oomol-lab/ovm-ssh-agent/v3 v3.0.0 h1:QRRornLkmEhMXjKwspfBsSh23VnqpRc+MycqprK5JWU=
68+
github.com/oomol-lab/ovm-ssh-agent/v3 v3.0.0/go.mod h1:AiTDS3XP3+8HY8Y0e9bhE6xXeirtTKvZxdtNcI6ra7g=
6969
github.com/oomol-lab/ssh-forward v0.0.0-20250319062521-6d0eb022abac h1:h+hNzgc4DtmjzMC2Fw5I766RsMb9GjLLsGZfmg5rp/g=
7070
github.com/oomol-lab/ssh-forward v0.0.0-20250319062521-6d0eb022abac/go.mod h1:/X60uEwaCA1Bt0AJ+6VShkjErRBbkDbzmqwxR8jPpMI=
7171
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=

pkg/machine/shim/ssh_auth.go

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@
44
package shim
55

66
import (
7-
"bauklotze/pkg/machine/channel"
8-
"bauklotze/pkg/machine/define"
9-
"bauklotze/pkg/machine/vmconfig"
107
"context"
118
"fmt"
12-
"net"
139
"os"
1410
"path/filepath"
1511

12+
"bauklotze/pkg/machine/channel"
13+
"bauklotze/pkg/machine/define"
14+
"bauklotze/pkg/machine/vmconfig"
15+
1616
"golang.org/x/sync/errgroup"
1717

18-
"github.com/oomol-lab/ovm-ssh-agent/pkg/sshagent"
19-
"github.com/oomol-lab/ovm-ssh-agent/pkg/system"
18+
"github.com/oomol-lab/ovm-ssh-agent/v3/pkg/sshagent"
19+
"github.com/oomol-lab/ovm-ssh-agent/v3/pkg/system"
2020

21-
"github.com/oomol-lab/ovm-ssh-agent/pkg/identity"
21+
"github.com/oomol-lab/ovm-ssh-agent/v3/pkg/identity"
2222
forwarder "github.com/oomol-lab/ssh-forward"
2323

2424
"github.com/sirupsen/logrus"
@@ -47,29 +47,20 @@ func startSSHAuthServiceAndForward(ctx context.Context, mc *vmconfig.MachineConf
4747
return fmt.Errorf("failed to remove local ssh agent socket: %w", err)
4848
}
4949

50-
listener, err := net.Listen("unix", localSocketFile)
51-
if err != nil {
52-
return fmt.Errorf("failed to listen unix socket: %w", err)
53-
}
54-
defer listener.Close()
55-
5650
upstreamSocket := system.GetSSHAgent()
5751
if upstreamSocket == "" {
5852
return fmt.Errorf("upstream SSH agent socket empty")
5953
}
6054
logrus.Infof("upstream ssh agent listened in: %q", upstreamSocket)
6155

62-
ooSSHAgent, err := sshagent.NewSSHAgent(ctx, upstreamSocket)
63-
if err != nil {
64-
return fmt.Errorf("failed to create oo ssh agent: %w", err)
65-
}
56+
ooSSHAgent := sshagent.NewSSHAgent(ctx, upstreamSocket, localSocketFile)
6657
defer ooSSHAgent.Close()
6758

6859
// find local private keys ~/.ssh
6960
ooSSHAgent.LoadLocalKeys(identity.FindPrivateKeys()...)
7061

7162
g.Go(func() error {
72-
return ooSSHAgent.Serve(listener)
63+
return ooSSHAgent.Serve()
7364
})
7465

7566
remoteSocketFile := "/opt/ssh_auth/oo-ssh-agent.sock"
@@ -106,5 +97,9 @@ func startSSHAuthServiceAndForward(ctx context.Context, mc *vmconfig.MachineConf
10697
return socketForwarder.Start(ctx)
10798
})
10899

109-
return g.Wait() //nolint:wrapcheck
100+
if err := g.Wait(); err != nil {
101+
return fmt.Errorf("failed to start ssh auth service: %w", err)
102+
}
103+
104+
return nil
110105
}

0 commit comments

Comments
 (0)