refactor(wsl): improve wsl check env code

Signed-off-by: Kevin Cui <bh@bugs.cc>

Author: BlackHole1

pkg/cli/init.go

@@ -89,7 +89,7 @@ func (c *InitContext) Start() error {
 		return util.WaitBindPID(ctx, c.Logger, c.BindPID)
 	})
 
-	wsl.Check(&c.InitOpt)
+	wsl.CheckEnv(&c.InitOpt)
 
 	select {
 	case <-ctx.Done():

pkg/wsl/check.go

@@ -24,7 +24,7 @@ var (
 	_isFeatureEnabled     bool
 )
 
-func Check(opt *types.InitOpt) {
+func CheckEnv(opt *types.InitOpt) {
 	log := opt.Logger
 
 	if isEnabled := isFeatureEnabled(log); !isEnabled {
@@ -36,21 +36,20 @@ func Check(opt *types.InitOpt) {
 
 	log.Info("WSL2 feature is already enabled")
 
-	shouldUpdate, err := shouldUpdateWSL(log)
-	if err == nil && !shouldUpdate {
-		log.Info("WSL2 is up to date")
-		channel.NotifyWSLEnvReady()
-		return
-	}
+	if shouldUpdate, err := shouldUpdateWSL(log); shouldUpdate {
+		if err != nil {
+			log.Warnf("Failed to check if WSL2 needs to be updated: %v", err)
+		} else {
+			log.Info("WSL2 needs to be updated")
+		}
 
-	if err != nil {
-		log.Warnf("Failed to check if WSL2 needs to be updated: %v", err)
-	} else {
-		log.Info("WSL2 needs to be updated")
+		event.NotifyInit(event.NeedUpdateWSL)
+		opt.CanUpdateWSL = true
+		return
 	}
 
-	event.NotifyInit(event.NeedUpdateWSL)
-	opt.CanUpdateWSL = true
+	log.Info("WSL2 is up to date")
+	channel.NotifyWSLEnvReady()
 	return
 }