Skip to content

Commit 01831c5

Browse files
committed
ci/release/docs: resolve Copilot feedback – Codecov step uses env check; add build-netfx gate; fail on missing NuGet artifact; remove duplicate branch protection doc; refine quality-gates publish
1 parent 8b17ad5 commit 01831c5

File tree

4 files changed

+11
-21
lines changed

4 files changed

+11
-21
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,15 @@ jobs:
6060
run: dotnet test AiDotNet.sln -c Release --no-build --collect:"XPlat Code Coverage" --results-directory ./TestResults
6161

6262
- name: Upload coverage to Codecov
63-
if: ${{ secrets.CODECOV_TOKEN != '' }}
64-
uses: codecov/codecov-action@v4
65-
with:
66-
token: ${{ secrets.CODECOV_TOKEN }}
67-
directory: ./TestResults
68-
fail_ci_if_error: true
63+
run: |
64+
if [ -n "${CODECOV_TOKEN}" ]; then
65+
echo "Uploading coverage to Codecov..."
66+
npx codecov -t "${CODECOV_TOKEN}" -d "./TestResults" || echo "Codecov upload failed"
67+
else
68+
echo "CODECOV_TOKEN not set; skipping Codecov upload."
69+
fi
70+
env:
71+
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
6972

7073
- name: Publish core library (sanity)
7174
run: |
@@ -151,6 +154,7 @@ jobs:
151154
run: |
152155
[ "${{ needs.lint-and-format.result }}" = "success" ] || (echo "Lint/format failed" && exit 1)
153156
[ "${{ needs.build.result }}" = "success" ] || (echo "Build failed" && exit 1)
157+
[ "${{ needs.build-netfx.result }}" = "success" ] || (echo ".NET Framework build failed" && exit 1)
154158
[ "${{ needs.test.result }}" = "success" ] || (echo "Tests failed" && exit 1)
155159
[ "${{ needs.integration-test.result }}" = "success" ] || (echo "Integration tests failed" && exit 1)
156160
echo "All checks passed!"

.github/workflows/commitlint.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,4 @@ jobs:
1616
uses: wagoid/commitlint-github-action@v6
1717
with:
1818
# An empty configFile parameter relies on commitlint's default configuration discovery.
19-
configFile: ''
2019

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
with:
7373
name: nuget-out-${{ github.sha }}
7474
path: out/*.nupkg
75-
if-no-files-found: ignore
75+
if-no-files-found: error
7676

7777
publish-nuget:
7878
name: Publish to NuGet

BRANCH_PROTECTION.md

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)