ci/release: fix test job matrix + indentation; correct Codecov step; fix release triggers, job if, and download artifacts for GitHub Release

Author: ooples

.github/workflows/ci.yml

@@ -97,18 +97,20 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Setup .NET 8.0.x
+      - name: Setup .NET ${{ matrix.dotnet }}
         uses: actions/setup-dotnet@v4
         with:
-          dotnet-version: 8.0.x
+          dotnet-version: ${{ matrix.dotnet }}
 
       - name: Restore
-run: dotnet restore AiDotNet.sln
+        run: dotnet restore AiDotNet.sln
       - name: Run tests with coverage
         run: |
           dotnet test AiDotNet.sln --configuration Release --collect:"XPlat Code Coverage" --results-directory ./TestResults
 
-      - name: Upload coverage to Codecov (only uploads if secret set)\n        uses: codecov/codecov-action@v4
+      - name: Upload coverage to Codecov (only if token set)
+        if: ${{ secrets.CODECOV_TOKEN != '' }}
+        uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: |

.github/workflows/release.yml

@@ -3,7 +3,7 @@ name: Release (.NET)
 on:
   push:
     branches:
-      - master
+      - merge-dev2-to-master
 
 permissions:
   contents: write
@@ -80,7 +80,7 @@ jobs:
     name: Publish to NuGet
     runs-on: ubuntu-latest
     needs: build-test-pack
-    if: secrets.NUGET_API_KEY != ''
+    if: ${{ secrets.NUGET_API_KEY != '' }}
     steps:
       - name: Download package
         uses: actions/download-artifact@v4
@@ -101,6 +101,12 @@ jobs:
     runs-on: ubuntu-latest
     needs: build-test-pack
     steps:
+      - name: Download package
+        uses: actions/download-artifact@v4
+        with:
+          name: nuget-out-${{ github.sha }}
+          path: out/
+
       - name: Create Release
         uses: softprops/action-gh-release@v2
         with: