fixed s3 validation on account update

Author: opaduchak

addon_imps/storage/s3.py

@@ -130,3 +130,10 @@ def list_buckets(self):
                 item_name=bucket["Name"] + "/",
                 item_type=storage.ItemType.FOLDER,
             )
+
+    async def get_external_account_id(self, auth_result_extras: dict[str, str]) -> str:
+        try:
+            self.client.list_buckets()
+            return ""
+        except BotoExceptions.ClientError:
+            raise ValidationError("Fail to validate access key and secret key")

addon_service/external_service/models.py

@@ -86,7 +86,7 @@ def service_type(self):
         return ServiceTypes(self.int_service_type)
 
     @property
-    def configurable_api_root(self):
+    def configurable_api_root(self) -> bool:
         return ServiceTypes.HOSTED in self.service_type
 
     @property

addon_service/external_service/storage/views.py

@@ -12,10 +12,6 @@
     list=extend_schema(
         description="Get the list of all available external storage services"
     ),
-    get=extend_schema(
-        description="Get particular external storage service",
-    ),
-    get_wb_credentials=extend_schema(exclude=True),
 )
 class ExternalStorageServiceViewSet(ReadOnlyModelViewSet):
     queryset = ExternalStorageService.objects.all().select_related(