-
Notifications
You must be signed in to change notification settings - Fork 3
Email and SMTP hardcoded in publisher scripts #515
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Various publisher (Perl) scripts have functionality to inform of a potentially hanging script.
The from, to, and SMTP host are all hardcoded.
See for example:
opal-admin-legacy/publisher/controls/announcementControl.pl
Lines 105 to 115 in 5bbd836
| # email error | |
| my $mime = MIME::Lite->new( | |
| 'From' => "opal\@muhc.mcgill.ca", | |
| 'To' => "gregormitchell\@gmail.com", | |
| # 'Cc' => "someone\@gmail.com", | |
| 'Subject' => "Potential hanging script - Opal announcementControl.pl", | |
| 'Type' => 'text/html', | |
| 'Data' => \@logs, | |
| ); | |
| my $response = $mime->send('smtp', '172.25.123.208'); |
This either needs to be configurable, or, since all scripts that run periodically are executed via Ofelia (which takes care of sending an email if a script fails), we remove this functionality completely.
I am tending to the latter option.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working