chore: replace herodevs' angularjs dependencies with original angularjs (#1419)

Removed all references to the `HeroDevs` Never-Ending Support for AngularJS, since our token has expired, and replaced them with the last published official AngularJS version, 1.8.3.

Author: staceybeard

.github/actions/build-setup/action.yml

@@ -6,9 +6,6 @@ name: Build App Setup
 description: Setup before building the app
 
 inputs:
-  NPMRC_FILE:
-    description: 'Secret with the contents of .npmrc'
-    required: true
   ENV_CONFIG_JS:
     description: 'Contents of the file `opal.config.js` for the given environment'
     required: true
@@ -22,8 +19,6 @@ runs:
     # Install dependencies
     - name: Install dependencies
       uses: ./.github/actions/install-dependencies
-      with:
-        NPMRC_FILE: ${{ inputs.NPMRC_FILE }}
 
     # Initialize the environment files needed to build the app from repository-level Actions variables
     - name: Load environment files

.github/actions/install-dependencies/action.yml

@@ -5,20 +5,10 @@
 name: Install Dependencies
 description: Install the dependencies needed by the app, using npm
 
-inputs:
-  NPMRC_FILE:
-    description: 'Secret with the contents of .npmrc'
-    required: true
-
 runs:
   using: "composite"
   steps:
       # Install dependencies
-      - name: Load .npmrc
-        run: echo "${NPMRC_FILE}" > .npmrc
-        shell: bash
-        env:
-          NPMRC_FILE: ${{ inputs.NPMRC_FILE }}
       # Use setup-node's built-in functionality for caching and restoring npm dependencies
       # See: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows
       - uses: actions/setup-node@v4.4.0

.github/workflows/build-deploy-app.yml

@@ -55,7 +55,6 @@ jobs:
       - name: Set up build
         uses: ./.github/actions/build-setup
         with:
-          NPMRC_FILE: ${{ secrets.NPMRC_FILE }}
           ENV_CONFIG_JS: ${{ vars[format('{0}_CONFIG_JS', env.ENVIRONMENT)] }}
           ENV_GOOGLE_SERVICES: ${{ vars[format('{0}_GOOGLE_SERVICES', env.ENVIRONMENT)] }}
 
@@ -92,7 +91,6 @@ jobs:
       - name: Set up build
         uses: ./.github/actions/build-setup
         with:
-          NPMRC_FILE: ${{ secrets.NPMRC_FILE }}
           ENV_CONFIG_JS: ${{ vars[format('{0}_CONFIG_JS', env.ENVIRONMENT)] }}
           ENV_GOOGLE_SERVICES: ${{ vars[format('{0}_GOOGLE_SERVICES', env.ENVIRONMENT)] }}
 

.github/workflows/build-deploy-web.yml

@@ -55,7 +55,6 @@ jobs:
       - name: Set up build
         uses: ./.github/actions/build-setup
         with:
-          NPMRC_FILE: ${{ secrets.NPMRC_FILE }}
           ENV_CONFIG_JS: ${{ vars[format('{0}_CONFIG_JS', env.ENVIRONMENT)] }}
           ENV_GOOGLE_SERVICES: ${{ vars[format('{0}_GOOGLE_SERVICES', env.ENVIRONMENT)] }}
 

.github/workflows/increment-version.yml

@@ -26,8 +26,6 @@ jobs:
           fetch-depth: ${{ vars.FETCH_DEPTH }}
       - name: Install dependencies
         uses: ./.github/actions/install-dependencies
-        with:
-          NPMRC_FILE: ${{ secrets.NPMRC_FILE }}
 
       # Increment the version
       - name: Run semantic-release

README.md

@@ -57,22 +57,19 @@ This section covers installation steps to build the app's web code on your local
 
 2.  Install the app's dependencies
 
-    Add the `.npmrc` file
+    ```shell
+    npm install
+    ```
 
     This project uses [AngularJS](https://angularjs.org/) which reached end of life in January 2022.
-    This project uses a long-term support version of AngularJS provided by [HeroDevs](https://www.herodevs.com/support/nes-angularjs).
-    If you have an `npm` token to retrieve this version from their registry, place the `.npmrc` file containing the credentials in the root directory.
 
-    You can also use the [last available version](https://www.npmjs.com/package/angular) of AngularJS (version 1.8.3).
-    To do so, change the value for the `angular` dependency to `angular@1.8.3` in `package.json`.
-    Also change all other auxiliary angular dependencies accessed through `neverendingsupport` to their latest default versions, as provided by npm.
-    Then, run:
+    A long-term support version of AngularJS can be used instead, provided by [HeroDevs](https://www.herodevs.com/support/nes-angularjs) (paid service).
+    If you have an `npm` token to retrieve this version from their registry, place the `.npmrc` file containing the credentials in the root directory.
 
-    ```shell
-    npm install
-    ```
+    Then, substitute the AngularJS dependencies in `package.json` with the packages provided by HeroDevs
+    (see [their setup instructions here](https://docs.herodevs.com/angularjs/angularjs-1-8#detailed-instructions)).
 
-    For a list of all dependencies, refer to [package.json](./package.json).
+    For a list of all dependencies used in this project, refer to [package.json](./package.json).
 
 3.  Connect your installation to a running backend.
 

THIRDPARTY.md

@@ -399,10 +399,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 ```
 
-### Notes
-
-We use the extended long-term support version provided by HeroDevs (paid service).
-
 ## angular-animate
 
 * Homepage: http://angularjs.org
@@ -433,10 +429,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 ```
 
-### Notes
-
-We use the extended long-term support version provided by HeroDevs (paid service).
-
 ## angular-dynamic-locale
 
 * Homepage: https://github.com/lgalfaso/angular-dynamic-locale#readme
@@ -497,10 +489,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 ```
 
-### Notes
-
-We use the extended long-term support version provided by HeroDevs (paid service).
-
 ## angular-touch
 
 * Homepage: http://angularjs.org
@@ -531,10 +519,6 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 ```
 
-### Notes
-
-We use the extended long-term support version provided by HeroDevs (paid service).
-
 ## angular-translate
 
 * Homepage: https://github.com/angular-translate/angular-translate#readme

package-lock.json

@@ -54,11 +54,11 @@
     "@zxcvbn-ts/language-common": "3.0.4",
     "@zxcvbn-ts/language-en": "3.0.2",
     "@zxcvbn-ts/language-fr": "3.0.2",
-    "angular": "npm:@neverendingsupport/angularjs@1.9.9",
-    "angular-animate": "npm:@neverendingsupport/angularjs@1.9.9-animate",
+    "angular": "1.8.3",
+    "angular-animate": "1.8.3",
     "angular-dynamic-locale": "0.1.38",
-    "angular-sanitize": "npm:@neverendingsupport/angularjs@1.9.9-sanitize",
-    "angular-touch": "npm:@neverendingsupport/angularjs@1.9.9-touch",
+    "angular-sanitize": "1.8.3",
+    "angular-touch": "1.8.3",
     "angular-translate": "2.19.1",
     "angular-translate-interpolation-messageformat": "2.19.1",
     "angular-translate-loader-partial": "2.19.1",

package.json

@@ -31,13 +31,12 @@
     // Group auxiliary angular-related updates
     {
       "matchDepPatterns": ["^angular"],
-      "excludePackagePatterns": ["^@neverendingsupport/"],
       "groupName": "auxiliary angular packages"
     },
-    // Group AngularJS Never-Ending Support updates (from HeroDevs)
+    // Group angular-translate updates
     {
-      "matchSourceUrlPrefixes": ["https://github.com/xlts-dev/"],
-      "groupName": "angularjs NES packages"
+      "matchPackagePatterns": ["^angular-translate"],
+      "groupName": "angular-translate packages"
     },
     // Rate-limit firebase-tools updates: first day of each month
     {
@@ -64,10 +63,5 @@
       "matchPackagePatterns": ["-loader$"],
       "groupName": "webpack loader packages",
     },
-    // Group angular-translate updates
-    {
-      "matchPackagePatterns": ["^angular-translate"],
-      "groupName": "angular-translate packages"
-    },
   ],
 }