refactoring: renaming variables and configuration keys

- config('log-viewer.defaults.log_sorting_method') -> config('log-viewer.defaults.file_sorting_method')
- key 'log_sort_by_time' -> 'files_sort_by_time' in IndexController
- LogViewer.log_sort_by_time -> LogViewer.files_sort_by_time in FileList.vue

docker compose run --rm php composer test
  Tests:    4 failed, 248 passed (815 assertions)
  Duration: 2.78s
  Random Order Seed: 1757604409

   FAIL  Tests\Feature\LogFoldersControllerTest
  ⨯ it can get the log files
  ⨯ it folders are sorted alphabetically descending when configured
   FAIL  Tests\Unit\LogIndex\LogIndexTest
  ⨯ it can save to the cache after building up the index
  ⨯ it compresses chunk if gzip is available

Author: yakoffka

config/log-viewer.php

@@ -288,8 +288,8 @@
         // Order to sort the folders. Other options: `Ascending`, `Descending`
         'folder_sorting_order' => SortingOrder::Descending,
 
-        // Method for sorting logs into directories. Other options: `Alphabetical`, `ModifiedTime`
-        'log_sorting_method' => FolderSortingMethod::ModifiedTime,
+        // Method for sorting log-files into directories. Other options: `Alphabetical`, `ModifiedTime`
+        'file_sorting_method' => FolderSortingMethod::ModifiedTime,
 
         // Order to sort the logs. Other options: `Ascending`, `Descending`
         'log_sorting_order' => SortingOrder::Descending,

public/app.js

@@ -1,5 +1,5 @@
 {
-    "/app.js": "/app.js?id=0c810fdd27597f4d9fff94af639da625",
+    "/app.js": "/app.js?id=64391c136df5323279f6bc14315c3654",
     "/app.css": "/app.css?id=5593a0331dd40729ff41e32a6035d872",
     "/img/log-viewer-128.png": "/img/log-viewer-128.png?id=d576c6d2e16074d3f064e60fe4f35166",
     "/img/log-viewer-32.png": "/img/log-viewer-32.png?id=f8ec67d10f996aa8baf00df3b61eea6d",

public/mix-manifest.json

@@ -45,10 +45,10 @@
         <div class="text-sm text-gray-500 dark:text-gray-400">
           <label for="file-sort-direction" class="sr-only">Sort direction</label>
           <select id="file-sort-direction" class="select" v-model="fileStore.direction">
-            <option v-if="!LogViewer.log_sort_by_time" value="asc">From A to Z</option>
-            <option v-if="!LogViewer.log_sort_by_time" value="desc">From Z to A</option>
-            <option v-if="LogViewer.log_sort_by_time" value="desc">Newest first</option>
-            <option v-if="LogViewer.log_sort_by_time" value="asc">Oldest first</option>
+            <option v-if="!LogViewer.files_sort_by_time" value="asc">From A to Z</option>
+            <option v-if="!LogViewer.files_sort_by_time" value="desc">From Z to A</option>
+            <option v-if="LogViewer.files_sort_by_time" value="desc">Newest first</option>
+            <option v-if="LogViewer.files_sort_by_time" value="asc">Oldest first</option>
           </select>
         </div>
       </div>

resources/js/components/FileList.vue

@@ -14,7 +14,7 @@ class FilesController
     public function index(Request $request)
     {
         $files = LogViewer::getFiles();
-        $sortingMethod = config('log-viewer.defaults.log_sorting_method', FolderSortingMethod::ModifiedTime);
+        $sortingMethod = config('log-viewer.defaults.file_sorting_method', FolderSortingMethod::ModifiedTime);
 
         if ($sortingMethod === FolderSortingMethod::ModifiedTime) {
             if ($request->query('direction', 'desc') === 'asc') {

src/Http/Controllers/FilesController.php

@@ -20,7 +20,7 @@ public function index(Request $request)
         $sortingMethod = config('log-viewer.defaults.folder_sorting_method', FolderSortingMethod::ModifiedTime);
         $sortingOrder = config('log-viewer.defaults.folder_sorting_order', SortingOrder::Descending);
 
-        $fileSortingMethod = config('log-viewer.defaults.log_sorting_method', FolderSortingMethod::ModifiedTime);
+        $fileSortingMethod = config('log-viewer.defaults.file_sorting_method', FolderSortingMethod::ModifiedTime);
         $fileSortingOrder = $request->query('direction', 'desc');
 
         if ($sortingMethod === FolderSortingMethod::Alphabetical) {

src/Http/Controllers/FoldersController.php

@@ -15,7 +15,7 @@ public function __invoke()
             abort(404);
         }
 
-        $log_sort_by_time = config('log-viewer.defaults.log_sorting_method') === FolderSortingMethod::ModifiedTime;
+        $files_sort_by_time = config('log-viewer.defaults.file_sorting_method') === FolderSortingMethod::ModifiedTime;
 
         return view(LogViewer::getViewLayout(), [
             'logViewerScriptVariables' => [
@@ -26,7 +26,7 @@ public function __invoke()
                 'path' => config('log-viewer.route_path'),
                 'back_to_system_url' => config('log-viewer.back_to_system_url'),
                 'back_to_system_label' => config('log-viewer.back_to_system_label'),
-                'log_sort_by_time' => $log_sort_by_time,
+                'files_sort_by_time' => $files_sort_by_time,
                 'max_log_size_formatted' => Utils::bytesForHumans(LogViewer::maxLogSize()),
                 'show_support_link' => config('log-viewer.show_support_link', true),
 

src/Http/Controllers/IndexController.php

@@ -9,7 +9,7 @@
 });
 
 it('you can get alphabetically sorted default desc logs files controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::Alphabetical]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]);
 
     generateLogFiles([
         'one.log',
@@ -29,7 +29,7 @@
 });
 
 it('you can get alphabetically sorted asc logs files controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::Alphabetical]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]);
 
     generateLogFiles([
         'one.log',
@@ -49,7 +49,7 @@
 });
 
 it('you can get alphabetically sorted desc logs files controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::Alphabetical]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]);
 
     generateLogFiles([
         'one.log',

tests/Feature/LogFilesControllerAlphaSortTest.php

@@ -9,7 +9,7 @@
 });
 
 it('you can get time sorted default desc logs files controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::ModifiedTime]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]);
 
     $names = [
         'one.log',
@@ -32,7 +32,7 @@
 });
 
 it('you can get time sorted desc logs files controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::ModifiedTime]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]);
 
     $names = [
         'one.log',
@@ -56,7 +56,7 @@
 });
 
 it('you can get time sorted asc logs files controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::ModifiedTime]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]);
 
     $names = [
         'one.log',

tests/Feature/LogFilesControllerTimeSortTest.php

@@ -10,7 +10,7 @@
 });
 
 it('you can get alphabetically sorted default desc logs folders controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::Alphabetical]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]);
 
     generateLogFiles([
         'sub/one.log',
@@ -30,7 +30,7 @@
 });
 
 it('you can get alphabetically sorted asc logs folders controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::Alphabetical]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]);
 
     generateLogFiles([
         'sub/one.log',
@@ -50,7 +50,7 @@
 });
 
 it('you can get alphabetically sorted desc logs folders controller', function () {
-    config(['log-viewer.defaults.log_sorting_method' => FolderSortingMethod::Alphabetical]);
+    config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]);
 
     generateLogFiles([
         'sub/one.log',