Fix PHP 8.5 deprecation - avoid using null as array key

Khuthaily · web-flow · commit 8d1660fe6d7f · 2025-11-23T17:36:53.000-07:00
This PR is backwards compatible and keeps the public API and behavior the same, but avoids the deprecation warning in PHP 8.5+.
diff --git a/src/LogFile.php b/src/LogFile.php
@@ -75,11 +75,13 @@ public function type(): LogType
 
     public function index(?string $query = null): LogIndex
     {
-        if (! isset($this->_logIndexCache[$query])) {
-            $this->_logIndexCache[$query] = new LogIndex($this, $query);
+        $cacheKey = $query ?? '';
+
+        if (! isset($this->_logIndexCache[$cacheKey])) {
+            $this->_logIndexCache[$cacheKey] = new LogIndex($this, $query);
         }
 
-        return $this->_logIndexCache[$query];
+        return $this->_logIndexCache[$cacheKey];
     }
 
     public function logs(): LogReaderInterface

Original file line number	Diff line number	Diff line change
`@@ -75,11 +75,13 @@ public function type(): LogType`
`75`	`75`
`76`	`76`	`public function index(?string $query = null): LogIndex`
`77`	`77`	`{`
`78`		`- if (! isset($this->_logIndexCache[$query])) {`
`79`		`- $this->_logIndexCache[$query] = new LogIndex($this, $query);`
	`78`	`+ $cacheKey = $query ?? '';`
	`79`	`+`
	`80`	`+ if (! isset($this->_logIndexCache[$cacheKey])) {`
	`81`	`+ $this->_logIndexCache[$cacheKey] = new LogIndex($this, $query);`
`80`	`82`	`}`
`81`	`83`
`82`		`- return $this->_logIndexCache[$query];`
	`84`	`+ return $this->_logIndexCache[$cacheKey];`
`83`	`85`	`}`
`84`	`86`
`85`	`87`	`public function logs(): LogReaderInterface`