Merge pull request #135 from opcodesio/bug/division-by-zero-on-empty-files

fix division by zero when there are empty log files

Author: arukompas

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "opcodesio/log-viewer",
-    "version": "v1.6.1",
+    "version": "v1.6.2",
     "description": "Fast and easy-to-use log viewer for your Laravel application",
     "keywords": [
         "arukompas",

src/Http/Controllers/IsScanRequiredController.php

@@ -20,7 +20,15 @@ public function __invoke()
             $file = $filesRequiringScans->filter(fn ($file) => $file->sizeInMB() > 10)->first();
 
             if (is_null($file)) {
-                $file = $filesRequiringScans->sortByDesc(fn ($file) => $file->size())->first();
+                $file = $filesRequiringScans
+                    ->sortByDesc(fn ($file) => $file->size())
+                    ->filter(fn ($file) => $file->size() > 0)
+                    ->first();
+            }
+
+            if (is_null($file)) {
+                // Haven't found any files that are not empty. No scan required.
+                return response()->json(['requires_scan' => false]);
             }
 
             $scanStart = microtime(true);

src/LogReader.php

@@ -579,6 +579,11 @@ public function requiresScan(): bool
 
     public function percentScanned(): int
     {
+        if ($this->file->size() <= 0) {
+            // empty file, so assume it has been fully scanned.
+            return 100;
+        }
+
         return 100 - intval(($this->numberOfNewBytes() / $this->file->size() * 100));
     }
 

src/MultipleLogReader.php

@@ -190,6 +190,12 @@ public function requiresScan(): bool
     public function percentScanned(): int
     {
         $totalFileBytes = $this->fileCollection->sum->size();
+
+        if ($totalFileBytes <= 0) {
+            // empty files, so assume they've been fully scanned
+            return 100;
+        }
+
         $missingScansBytes = $this->fileCollection->sum(function (LogFile $file) {
             return $this->getLogQueryForFile($file)->numberOfNewBytes();
         });