diff --git a/.gitignore b/.gitignore index cf5556ab..772e1015 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,7 @@ build composer.lock coverage docs +logs phpunit.xml phpstan.neon testbench.yaml diff --git a/config/log-viewer.php b/config/log-viewer.php index 25eee2c6..9fb0c996 100644 --- a/config/log-viewer.php +++ b/config/log-viewer.php @@ -1,6 +1,6 @@ true, // Method to sort the folders. Other options: `Alphabetical`, `ModifiedTime` - 'folder_sorting_method' => FolderSortingMethod::ModifiedTime, + 'folder_sorting_method' => SortingMethod::ModifiedTime, // Order to sort the folders. Other options: `Ascending`, `Descending` 'folder_sorting_order' => SortingOrder::Descending, // Method for sorting log-files into directories. Other options: `Alphabetical`, `ModifiedTime` - 'file_sorting_method' => FolderSortingMethod::ModifiedTime, + 'file_sorting_method' => SortingMethod::ModifiedTime, // Order to sort the logs. Other options: `Ascending`, `Descending` 'log_sorting_order' => SortingOrder::Descending, diff --git a/src/Enums/FolderSortingMethod.php b/src/Enums/FolderSortingMethod.php index 1d0ec5bd..b770c877 100644 --- a/src/Enums/FolderSortingMethod.php +++ b/src/Enums/FolderSortingMethod.php @@ -2,6 +2,9 @@ namespace Opcodes\LogViewer\Enums; +/** + * @deprecated Use SortingMethod instead + */ class FolderSortingMethod { public const Alphabetical = 'Alphabetical'; diff --git a/src/Enums/SortingMethod.php b/src/Enums/SortingMethod.php new file mode 100644 index 00000000..af2b6ae6 --- /dev/null +++ b/src/Enums/SortingMethod.php @@ -0,0 +1,9 @@ +validateDirection($request->query('direction')); - if ($sortingMethod === FolderSortingMethod::ModifiedTime) { - if ($request->query('direction', 'desc') === 'asc') { + if ($sortingMethod === SortingMethod::ModifiedTime) { + if ($direction === SortingOrder::Ascending) { $files = $files->sortByEarliestFirst(); } else { $files = $files->sortByLatestFirst(); } } else { - if ($request->query('direction', 'desc') === 'asc') { + if ($direction === SortingOrder::Ascending) { $files = $files->sortAlphabeticallyAsc(); } else { $files = $files->sortAlphabeticallyDesc(); @@ -34,6 +36,15 @@ public function index(Request $request) return LogFileResource::collection($files); } + private function validateDirection(?string $direction): string + { + if ($direction === SortingOrder::Ascending) { + return SortingOrder::Ascending; + } + + return SortingOrder::Descending; + } + public function requestDownload(Request $request, string $fileIdentifier) { $file = LogViewer::getFile($fileIdentifier); diff --git a/src/Http/Controllers/FoldersController.php b/src/Http/Controllers/FoldersController.php index 7313715e..783a3ee7 100644 --- a/src/Http/Controllers/FoldersController.php +++ b/src/Http/Controllers/FoldersController.php @@ -5,7 +5,7 @@ use Illuminate\Http\Request; use Illuminate\Support\Facades\Gate; use Illuminate\Support\Facades\URL; -use Opcodes\LogViewer\Enums\FolderSortingMethod; +use Opcodes\LogViewer\Enums\SortingMethod; use Opcodes\LogViewer\Enums\SortingOrder; use Opcodes\LogViewer\Facades\LogViewer; use Opcodes\LogViewer\Http\Resources\LogFolderResource; @@ -17,20 +17,20 @@ public function index(Request $request) { $folders = LogViewer::getFilesGroupedByFolder(); - $sortingMethod = config('log-viewer.defaults.folder_sorting_method', FolderSortingMethod::ModifiedTime); + $sortingMethod = config('log-viewer.defaults.folder_sorting_method', SortingMethod::ModifiedTime); $sortingOrder = config('log-viewer.defaults.folder_sorting_order', SortingOrder::Descending); - $fileSortingMethod = config('log-viewer.defaults.file_sorting_method', FolderSortingMethod::ModifiedTime); - $fileSortingOrder = $request->query('direction', 'desc'); + $fileSortingMethod = config('log-viewer.defaults.file_sorting_method', SortingMethod::ModifiedTime); + $fileSortingOrder = $this->validateDirection($request->query('direction')); - if ($sortingMethod === FolderSortingMethod::Alphabetical) { + if ($sortingMethod === SortingMethod::Alphabetical) { if ($sortingOrder === SortingOrder::Ascending) { $folders = $folders->sortAlphabeticallyAsc(); } else { $folders = $folders->sortAlphabeticallyDesc(); } } else { // ModifiedTime - if ($fileSortingOrder === 'asc') { + if ($fileSortingOrder === SortingOrder::Ascending) { $folders = $folders->sortByEarliestFirstIncludingFiles(); } else { $folders = $folders->sortByLatestFirstIncludingFiles(); @@ -39,15 +39,15 @@ public function index(Request $request) // Sort files within folders after sorting folders $folders->each(function ($folder) use ($fileSortingMethod, $fileSortingOrder) { - if ($fileSortingMethod === FolderSortingMethod::ModifiedTime) { - if ($fileSortingOrder === 'asc') { + if ($fileSortingMethod === SortingMethod::ModifiedTime) { + if ($fileSortingOrder === SortingOrder::Ascending) { $folder->files()->sortByEarliestFirst(); } else { $folder->files()->sortByLatestFirst(); } } else { - if ($fileSortingOrder === 'asc') { + if ($fileSortingOrder === SortingOrder::Ascending) { $folder->files()->sortAlphabeticallyAsc(); } else { $folder->files()->sortAlphabeticallyDesc(); @@ -58,6 +58,15 @@ public function index(Request $request) return LogFolderResource::collection($folders->values()); } + private function validateDirection(?string $direction): string + { + if ($direction === SortingOrder::Ascending) { + return SortingOrder::Ascending; + } + + return SortingOrder::Descending; + } + public function requestDownload(Request $request, string $folderIdentifier) { $folder = LogViewer::getFolder($folderIdentifier); diff --git a/src/Http/Controllers/IndexController.php b/src/Http/Controllers/IndexController.php index 7fbe780e..68119c8d 100644 --- a/src/Http/Controllers/IndexController.php +++ b/src/Http/Controllers/IndexController.php @@ -2,7 +2,7 @@ namespace Opcodes\LogViewer\Http\Controllers; -use Opcodes\LogViewer\Enums\FolderSortingMethod; +use Opcodes\LogViewer\Enums\SortingMethod; use Opcodes\LogViewer\Facades\LogViewer; use Opcodes\LogViewer\LogFolder; use Opcodes\LogViewer\Utils\Utils; @@ -15,7 +15,7 @@ public function __invoke() abort(404); } - $files_sort_by_time = config('log-viewer.defaults.file_sorting_method') === FolderSortingMethod::ModifiedTime; + $files_sort_by_time = config('log-viewer.defaults.file_sorting_method') === SortingMethod::ModifiedTime; return view(LogViewer::getViewLayout(), [ 'logViewerScriptVariables' => [ diff --git a/tests/Feature/InvalidSortingValuesTest.php b/tests/Feature/InvalidSortingValuesTest.php new file mode 100644 index 00000000..9a65ec10 --- /dev/null +++ b/tests/Feature/InvalidSortingValuesTest.php @@ -0,0 +1,178 @@ + ['*.log', '*/**.log']]); +}); + +// FilesController with invalid sorting values + +it('files controller returns default desc order when invalid direction is provided', function () { + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); + $names = ['one.log', 'two.log', 'three.log']; + generateLogFiles($names, randomContent: true); + + array_map(function (string $name) { + $this->travelTo(now()->addSecond()); + touch(storage_path('logs/'.$name), now()->timestamp); + }, $names); + + $response = getJson(route('log-viewer.files', ['direction' => 'invalid'])); + + expect(array_column($response->json(), 'name'))->toBe([ + 'three.log', + 'two.log', + 'one.log', + ]); +}); + +it('files controller returns default desc order when empty direction is provided', function () { + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); + $names = ['one.log', 'two.log', 'three.log']; + generateLogFiles($names, randomContent: true); + + array_map(function (string $name) { + $this->travelTo(now()->addSecond()); + touch(storage_path('logs/'.$name), now()->timestamp); + }, $names); + + $response = getJson(route('log-viewer.files', ['direction' => ''])); + + expect(array_column($response->json(), 'name'))->toBe([ + 'three.log', + 'two.log', + 'one.log', + ]); +}); + +it('files controller returns default desc order when direction is null', function () { + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); + $names = ['one.log', 'two.log', 'three.log']; + generateLogFiles($names, randomContent: true); + + array_map(function (string $name) { + $this->travelTo(now()->addSecond()); + touch(storage_path('logs/'.$name), now()->timestamp); + }, $names); + + $response = getJson(route('log-viewer.files')); + + expect(array_column($response->json(), 'name'))->toBe([ + 'three.log', + 'two.log', + 'one.log', + ]); +}); + +it('files controller returns alphabetical sorting with default desc when invalid direction is provided', function () { + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); + generateLogFiles(['one.log', 'two.log', 'three.log', 'four.log'], randomContent: true); + + $response = getJson(route('log-viewer.files', ['direction' => 'invalid'])); + + expect(array_column($response->json(), 'name'))->toBe([ + 'two.log', + 'three.log', + 'one.log', + 'four.log', + ]); +}); + +it('files controller returns correct order with valid asc direction and alphabetical sorting', function () { + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); + generateLogFiles(['one.log', 'two.log', 'three.log', 'four.log'], randomContent: true); + + $response = getJson(route('log-viewer.files', ['direction' => SortingOrder::Ascending])); + + expect(array_column($response->json(), 'name'))->toBe([ + 'four.log', + 'one.log', + 'three.log', + 'two.log', + ]); +}); + +// FoldersController with invalid sorting values + +it('folders controller returns default desc order when invalid direction is provided', function () { + config(['log-viewer.include_files' => ['*/**.log']]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); + $names = ['sub/one.log', 'sub/two.log', 'sub/three.log']; + generateLogFiles($names, randomContent: true); + + array_map(function (string $name) { + $this->travelTo(now()->addSecond()); + touch(storage_path('logs/'.$name), now()->timestamp); + }, $names); + + $response = getJson(route('log-viewer.folders', ['direction' => 'invalid'])); + + expect(array_column($response->json()[0]['files'], 'name'))->toBe([ + 'three.log', + 'two.log', + 'one.log', + ]); +}); + +it('folders controller returns default desc order when empty direction is provided', function () { + config(['log-viewer.include_files' => ['*/**.log']]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); + $names = ['sub/one.log', 'sub/two.log', 'sub/three.log']; + generateLogFiles($names, randomContent: true); + + array_map(function (string $name) { + $this->travelTo(now()->addSecond()); + touch(storage_path('logs/'.$name), now()->timestamp); + }, $names); + + $response = getJson(route('log-viewer.folders', ['direction' => ''])); + + expect(array_column($response->json()[0]['files'], 'name'))->toBe([ + 'three.log', + 'two.log', + 'one.log', + ]); +}); + +it('folders controller returns default desc order when direction is null', function () { + config(['log-viewer.include_files' => ['*/**.log']]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); + $names = ['sub/one.log', 'sub/two.log', 'sub/three.log']; + generateLogFiles($names, randomContent: true); + + array_map(function (string $name) { + $this->travelTo(now()->addSecond()); + touch(storage_path('logs/'.$name), now()->timestamp); + }, $names); + + $response = getJson(route('log-viewer.folders')); + + expect(array_column($response->json()[0]['files'], 'name'))->toBe([ + 'three.log', + 'two.log', + 'one.log', + ]); +}); + +it('folders controller returns correct order with valid asc direction and alphabetical sorting', function () { + config(['log-viewer.include_files' => ['*/**.log']]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); + generateLogFiles(['sub/one.log', 'sub/two.log', 'sub/three.log', 'sub/four.log'], randomContent: true); + + $response = getJson(route('log-viewer.folders', ['direction' => SortingOrder::Ascending])); + + expect(array_column($response->json()[0]['files'], 'name'))->toBe([ + 'four.log', + 'one.log', + 'three.log', + 'two.log', + ]); +}); diff --git a/tests/Feature/LogFilesControllerAlphaSortTest.php b/tests/Feature/LogFilesControllerAlphaSortTest.php index 4a6b4193..c1cb444e 100644 --- a/tests/Feature/LogFilesControllerAlphaSortTest.php +++ b/tests/Feature/LogFilesControllerAlphaSortTest.php @@ -1,6 +1,6 @@ FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); generateLogFiles([ 'one.log', @@ -30,8 +30,8 @@ }); it('you can get alphabetically sorted asc logs files controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); generateLogFiles([ 'one.log', @@ -51,8 +51,8 @@ }); it('you can get alphabetically sorted desc logs files controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); generateLogFiles([ 'one.log', @@ -72,8 +72,8 @@ }); it('you can get alphabetically sorted default desc logs files controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); generateLogFiles([ 'one.log', @@ -93,8 +93,8 @@ }); it('you can get alphabetically sorted asc logs files controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); generateLogFiles([ 'one.log', @@ -114,8 +114,8 @@ }); it('you can get alphabetically sorted desc logs files controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); generateLogFiles([ 'one.log', diff --git a/tests/Feature/LogFilesControllerTimeSortTest.php b/tests/Feature/LogFilesControllerTimeSortTest.php index 8e8f0d83..efcb6adf 100644 --- a/tests/Feature/LogFilesControllerTimeSortTest.php +++ b/tests/Feature/LogFilesControllerTimeSortTest.php @@ -1,6 +1,6 @@ FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'one.log', 'two.log', @@ -32,8 +32,8 @@ }); it('you can get time sorted desc logs files controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'one.log', 'two.log', @@ -56,8 +56,8 @@ }); it('you can get time sorted asc logs files controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'one.log', 'two.log', @@ -79,8 +79,8 @@ }); it('you can get time sorted default desc logs files controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'one.log', 'two.log', @@ -102,8 +102,8 @@ }); it('you can get time sorted desc logs files controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'one.log', 'two.log', @@ -126,8 +126,8 @@ }); it('you can get time sorted asc logs files controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'one.log', 'two.log', diff --git a/tests/Feature/LogFoldersControllerAlphaSortTest.php b/tests/Feature/LogFoldersControllerAlphaSortTest.php index 868f6cfb..97b25b79 100644 --- a/tests/Feature/LogFoldersControllerAlphaSortTest.php +++ b/tests/Feature/LogFoldersControllerAlphaSortTest.php @@ -1,6 +1,6 @@ FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); $names = [ 'sub/one.log', 'sub/two.log', @@ -35,8 +35,8 @@ }); it('you can get alphabetically sorted asc logs folders controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); $names = [ 'sub/one.log', 'sub/two.log', @@ -60,8 +60,8 @@ }); it('you can get alphabetically sorted desc logs folders controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); $names = [ 'sub/one.log', 'sub/two.log', @@ -84,10 +84,10 @@ ]); }); -// не работает сортировка файлов при config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]) +// не работает сортировка файлов при config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]) it('you can get alphabetically sorted default desc logs folders controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); $names = [ 'sub/one.log', 'sub/two.log', @@ -111,8 +111,8 @@ }); it('you can get alphabetically sorted asc logs folders controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); $names = [ 'sub/one.log', 'sub/two.log', @@ -136,8 +136,8 @@ }); it('you can get alphabetically sorted desc logs folders controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::Alphabetical]); $names = [ 'sub/one.log', 'sub/two.log', diff --git a/tests/Feature/LogFoldersControllerTest.php b/tests/Feature/LogFoldersControllerTest.php index 05064826..d47dcee5 100644 --- a/tests/Feature/LogFoldersControllerTest.php +++ b/tests/Feature/LogFoldersControllerTest.php @@ -1,6 +1,6 @@ FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); config(['log-viewer.defaults.folder_sorting_order' => SortingOrder::Descending]); generateLogFiles([ @@ -30,7 +30,7 @@ it('folders are sorted alphabetically descending when configured', function () { config(['log-viewer.include_files' => ['*.log', '*/**.log']]); - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); config(['log-viewer.defaults.folder_sorting_order' => SortingOrder::Ascending]); generateLogFiles([ diff --git a/tests/Feature/LogFoldersControllerTimeSortTest.php b/tests/Feature/LogFoldersControllerTimeSortTest.php index d7d1b4de..c6f1827c 100644 --- a/tests/Feature/LogFoldersControllerTimeSortTest.php +++ b/tests/Feature/LogFoldersControllerTimeSortTest.php @@ -1,6 +1,6 @@ FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'sub/one.log', 'sub/two.log', @@ -34,8 +34,8 @@ }); it('you can get time sorted desc logs folders controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'sub/one.log', 'sub/two.log', @@ -58,8 +58,8 @@ }); it('you can get time sorted asc logs folders controller 1', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::Alphabetical]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::Alphabetical]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'sub/one.log', 'sub/two.log', @@ -81,8 +81,8 @@ }); it('you can get time sorted default desc logs folders controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'sub/one.log', 'sub/two.log', @@ -104,8 +104,8 @@ }); it('you can get time sorted desc logs folders controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'sub/one.log', 'sub/two.log', @@ -127,8 +127,8 @@ }); it('you can get time sorted asc logs folders controller 2', function () { - config(['log-viewer.defaults.folder_sorting_method' => FolderSortingMethod::ModifiedTime]); - config(['log-viewer.defaults.file_sorting_method' => FolderSortingMethod::ModifiedTime]); + config(['log-viewer.defaults.folder_sorting_method' => SortingMethod::ModifiedTime]); + config(['log-viewer.defaults.file_sorting_method' => SortingMethod::ModifiedTime]); $names = [ 'sub/one.log', 'sub/two.log',