#53 - fixedFooter is displayed for HasOne, BelongsTo, MorphIne relations

open-admin-org · open-admin-org · commit bf53c096355b · 2023-04-03T00:01:03.000+02:00
- only set fixedFooter for Grid
diff --git a/src/Show/Relation.php b/src/Show/Relation.php
@@ -53,9 +53,9 @@ class Relation extends Field
      */
     public function __construct($name, $builder, $title = '')
     {
-        $this->name = $name;
+        $this->name    = $name;
         $this->builder = $builder;
-        $this->title = $this->formatLabel($title);
+        $this->title   = $this->formatLabel($title);
     }
 
     /**
@@ -121,11 +121,10 @@ public function render()
 
             $renderable->setName($this->name)
                 ->setTitle($this->title)
-                ->setRelation($relation);
+                ->setRelation($relation)
+                ->fixedFooter(false);
         }
 
-        $renderable->fixedFooter(false);
-
         return $renderable->render();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -53,9 +53,9 @@ class Relation extends Field`
`53`	`53`	`*/`
`54`	`54`	`public function __construct($name, $builder, $title = '')`
`55`	`55`	`{`
`56`		`- $this->name = $name;`
	`56`	`+ $this->name = $name;`
`57`	`57`	`$this->builder = $builder;`
`58`		`- $this->title = $this->formatLabel($title);`
	`58`	`+ $this->title = $this->formatLabel($title);`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`/**`
`@@ -121,11 +121,10 @@ public function render()`
`121`	`121`
`122`	`122`	`$renderable->setName($this->name)`
`123`	`123`	`->setTitle($this->title)`
`124`		`- ->setRelation($relation);`
	`124`	`+ ->setRelation($relation)`
	`125`	`+ ->fixedFooter(false);`
`125`	`126`	`}`
`126`	`127`
`127`		`- $renderable->fixedFooter(false);`
`128`		`-`
`129`	`128`	`return $renderable->render();`
`130`	`129`	`}`
`131`	`130`	`}`