include at least one DEBUG build on CI (+fix two asserts which had unnoticed errors) (#190)

Author: slayoo

.github/workflows/tests+artifacts+pypi.yml

@@ -15,21 +15,21 @@ on:
     types: [published]
 
 jobs:
-  todos_annotated:
+  todos_annotated_and_debug_build_ok:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
         with:
           submodules: recursive
           fetch-depth: 0  # https://github.com/pypa/setuptools_scm/issues/480
       - run: pip install -r test-time-requirements.txt
-      - run: DEBUG=0 VERBOSE=1 pip install --verbose -e .
+      - run: DEBUG=1 VERBOSE=1 pip install --verbose -e .
       - env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: pytest -v -s -We -p no:unraisableexception tests/test_todos_annotated.py
 
   build:
-    needs: [todos_annotated]
+    needs: [todos_annotated_and_debug_build_ok]
     strategy:
       matrix:
         platform: [ubuntu-latest, macos-12, windows-latest]

src/fake_spec_file.cpp

@@ -219,7 +219,7 @@ void c_spec_file_read_line(
 
     int i = 0;
     for (const auto &ch : name) {
-        assert(i < name_size);
+        assert(i < *name_size);
         name_data[i++] = ch;
     }
     *name_size = i;

src/gimmicks.hpp

@@ -102,6 +102,10 @@ struct Gimmick {
         return this->json->empty();
     }
 
+    auto size() noexcept {
+        return this->json->size();
+    }
+
     std::size_t n_elements(const bpstd::string_view &name) noexcept {
         for (auto i=0u; i<this->json->size(); ++i) {
             for (auto &entry : this->json->at(i).items()) {
@@ -227,7 +231,7 @@ struct InputGimmick: Gimmick {
         }
 
         if (!eof) {
-            assert(this>size() == 1);
+            assert(this->size() == 1);
             auto key = this->last_dict_key();
             if (this->key_name != "" && (this->key_cond == this->last_read_line_key)) {
                 name = this->key_name;