cleanups in test_gas_state (#177)

Author: slayoo

tests/test_gas_state.py

@@ -4,12 +4,8 @@
 # Authors: https://github.com/open-atmos/PyPartMC/graphs/contributors                              #
 ####################################################################################################
 
-# TODO #123
-# pylint: disable=unused-variable
-
 import pytest
 
-# import numpy as np
 import PyPartMC as ppmc
 
 from .test_gas_data import GAS_DATA_CTOR_ARG_MINIMAL
@@ -18,24 +14,9 @@
 
 
 class TestGasState:
-    @staticmethod
-    def test_ctor_error():
-        # arrange
-        pass
-
-        # act
-        # try:
-        #    sut = ppmc.GasState({'':''})
-        # except ValueError as err:
-        #    assert "gas_mixing_ratio" in str(err)
-        #    return
-
-        # assert
-        # assert False
-
     @staticmethod
     def test_ctor_valid():
-        # arrange
+        # act
         sut = ppmc.GasState(GAS_DATA_MINIMAL)
 
         # assert
@@ -49,17 +30,19 @@ def test_get_item_out_of_range(idx):
 
         # act
         try:
-            value = sut[idx]
+            _ = sut[idx]
         except IndexError:
             return
 
+        # assert
         assert False
 
     @staticmethod
     def test_get_item_valid():
         # arrange
         sut = ppmc.GasState(GAS_DATA_MINIMAL)
         sut[0] = 44
+
         # act
         value = sut[0]
 
@@ -102,22 +85,11 @@ def test_set_item():
 
     @staticmethod
     def test_get_mix_rats():
-
+        # arrange
         gas_data = GAS_DATA_MINIMAL
+
+        # act
         sut = ppmc.GasState(gas_data)
 
+        # assert
         assert len(sut.mix_rats) == len(sut)
-
-
-#    @staticmethod
-#    def test_to_json():
-#        # arrange
-#        data_in = {}  # TODO #123
-#        sut = ppmc.GasState(data_in)
-#
-#        # act
-#        data_out = str(sut)
-#        print(data_out)
-#
-#        # assert
-#        # assert data_in == data_out  TODO #123