Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.97%. Comparing base (000e688) to head (37dfc43).

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   91.04%   91.97%   +0.92%     
==========================================
  Files          55       56       +1     
  Lines        2636     2578      -58     
  Branches      144      144              
==========================================
- Hits         2400     2371      -29     
+ Misses        163      132      -31     
- Partials       73       75       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Maybe it would be beneficial to "abstract" the templates even more? get_value and set_value look the same in env_state.hpp and aero_particle.hpp. Maybe we could do something like this in a separate header (named getters.hpp ?):

namespace pypartmc { // possible namespace to avoid name conflicts

template <typename T, typename SelfType, typename Func>
inline T get_value(const SelfType &self, Func func) { // inline to keep it header-only
    T value{};
    func(self.ptr.f_arg(), &value);
    return value;
}

template <typename T, typename SelfType, typename Func>
inline void set_value(SelfType &self, Func func, T value) {
    func(self.ptr.f_arg_non_const(), &value);
}

}

And an example call would look like:

static auto get_height(const EnvState &self) {
     return pypartmc::get_value<double>(self, f_env_state_get_height);
}

The same could be considered for get_derived_value and get_derived_value_env_state. I'm not sure if these ones have a lot of uses in other classes, but even if they do not now, they could do in the future!

@jcurtis2, @Griger5, IIUC this is ready for merging, but could be extended with usage of the new templated setter and getters in other files, right?

@jcurtis2, CI is now fixed here.

Codecov detects two missing lines, which are a bit puzzling, but potentially seem to be a pair of important misses:

and