Skip to content

APR_CALCULATION_FIX.md

Latest commit

 

History

History
293 lines (219 loc) · 6.35 KB

APR_CALCULATION_FIX.md

File metadata and controls

293 lines (219 loc) · 6.35 KB

APR Calculation Fix

Problem

APRs displayed in CreditRamp were incorrect compared to the official Blend UI at https://testnet.blend.capital/

Example:

  • Blend UI shows: 7.32%
  • CreditRamp showed: 0.07% ❌

Root Cause

Incorrect understanding of the Blend SDK's APR format.

What We Thought

// We assumed SDK returned percentage (7.32)
reserve.supplyApr = 7.32

// So we multiplied by 100 to get basis points
supplyApr: Math.round(reserve.supplyApr * 100)  // 7.32 * 100 = 732

What SDK Actually Returns

Looking at the SDK source code (reserve.js):

const supplyApr = FixedMath.toFloat(curIr, 7);  // Returns DECIMAL
this.supplyApr = supplyApr;  // 0.0732 for 7.32%

SDK returns APR as a decimal: 0.0732 (not 7.32)

Our Incorrect Conversion

// Step 1: Store (WRONG)
supplyApr: Math.round(reserve.supplyApr * 100)
// 0.0732 * 100 = 7.32 → rounds to 7

// Step 2: Display (WRONG)
(reserve.supplyApr / 100).toFixed(2)
// 7 / 100 = 0.07%  ❌ INCORRECT!

Solution

Fixed Conversion

In lib/blend.ts (line 93-94):

// BEFORE (WRONG)
supplyApr: Math.round(reserve.supplyApr * 100),    // ❌ Wrong multiplier
borrowApr: Math.round(reserve.borrowApr * 100),    // ❌ Wrong multiplier

// AFTER (CORRECT)
supplyApr: Math.round(reserve.supplyApr * 10000),  // ✅ Correct: 0.0732 * 10000 = 732 bp
borrowApr: Math.round(reserve.borrowApr * 10000),  // ✅ Correct: 0.12 * 10000 = 1200 bp

Why 10000?

Basis Points Conversion:

  • 1% = 100 basis points
  • 7.32% = 732 basis points

From SDK decimal to basis points:

0.0732 (decimal) × 10000 = 732 (basis points)

From basis points to percentage (display):

732 (basis points) ÷ 100 = 7.32%

Data Flow

Before (Incorrect)

SDK Returns
    ↓
0.0732 (decimal for 7.32%)
    ↓
Math.round(0.0732 * 100) = 7
    ↓
Display: 7 / 100 = 0.07%  ❌

After (Correct)

SDK Returns
    ↓
0.0732 (decimal for 7.32%)
    ↓
Math.round(0.0732 * 10000) = 732 (basis points)
    ↓
Display: 732 / 100 = 7.32%  ✅

Examples

USDC Supply APR

SDK Value: reserve.supplyApr = 0.0732

Storage:

supplyApr: Math.round(0.0732 * 10000) = 732
// Stored as 732 basis points

Display:

(732 / 100).toFixed(2) = "7.32%"  ✅

XLM Supply APR

SDK Value: reserve.supplyApr = 0.0515

Storage:

supplyApr: Math.round(0.0515 * 10000) = 515
// Stored as 515 basis points

Display:

(515 / 100).toFixed(2) = "5.15%"  ✅

Borrow APR Example

SDK Value: reserve.borrowApr = 0.1234

Storage:

borrowApr: Math.round(0.1234 * 10000) = 1234
// Stored as 1234 basis points

Display:

(1234 / 100).toFixed(2) = "12.34%"  ✅

Code Changes

File: lib/blend.ts

Lines 93-94:

  reserves.set(assetSymbol, {
    assetId: reserve.assetId,
    symbol: assetSymbol,
-   supplyApr: Math.round(reserve.supplyApr * 100),
-   borrowApr: Math.round(reserve.borrowApr * 100),
+   supplyApr: Math.round(reserve.supplyApr * 10000), // SDK returns decimal (0.0732), convert to basis points (732)
+   borrowApr: Math.round(reserve.borrowApr * 10000), // SDK returns decimal (0.12), convert to basis points (1200)
    totalSupply: totalSupply,
    totalBorrow: totalLiabilities,
    utilizationRate: Math.round(utilizationRate),
    collateralFactor: Math.round(reserve.getCollateralFactor() * 100),
    liquidationFactor: Math.round(reserve.getLiabilityFactor() * 100),
  });

Display Code (unchanged, already correct)

In components/PoolCards.tsx (line 69-70):

const supplyAprDisplay = (reserve.supplyApr / 100).toFixed(2);
const borrowAprDisplay = (reserve.borrowApr / 100).toFixed(2);
// Now correctly displays: 732 / 100 = 7.32%

In app/page.tsx (line 486):

setApr(reserve.supplyApr / 100);
// Now correctly sets: 732 / 100 = 7.32%

Verification

Test with Blend Official UI

Blend Testnet USDC Pool: https://testnet.blend.capital/asset/?poolId=CDDG7DLOWSHRYQ2HWGZEZ4UTR7LPTKFFHN3QUCSZEXOWOPARMONX6T65&assetId=CAQCFVLOBK5GIULPNZRGATJJMIZL5BSP7X5YJVMGCPTUEPFM4AVSRCJU

Compare:

  1. Note the Supply APR on Blend UI (e.g., 7.32%)
  2. Check CreditRamp app - should now match exactly ✅

Console Verification

// In browser console after connecting wallet:
const pool = blendPools[0];
const reserve = pool.reserves.get('USDC');
console.log('Supply APR (basis points):', reserve.supplyApr);  // 732
console.log('Supply APR (percentage):', reserve.supplyApr / 100);  // 7.32

Impact

Before Fix

  • All APRs were ~100x too small
  • 7.32% showed as 0.07%
  • 12.50% showed as 0.12%

After Fix

  • APRs now match Blend official UI exactly ✅
  • 7.32% shows as 7.32% ✅
  • 12.50% shows as 12.50% ✅

Related Types

PoolReserve Interface

export interface PoolReserve {
  assetId: string;
  symbol: string;
  supplyApr: number;  // Stored as basis points (732 for 7.32%)
  borrowApr: number;  // Stored as basis points (1200 for 12.00%)
  totalSupply: bigint;
  totalBorrow: bigint;
  utilizationRate: number;  // percentage
  collateralFactor: number;  // percentage
  liquidationFactor: number;  // percentage
}

Build Status

✅ Build successful - No errors

✓ Compiled successfully
✓ Generating static pages (9/9)
Route (app)     Size     First Load JS
┌ ○ /           688 kB   772 kB

Testing Checklist

  • Connect wallet to testnet
  • Load pools
  • Compare USDC APR with Blend UI
    • Supply APR matches
    • Borrow APR matches
  • Compare XLM APR with Blend UI
    • Supply APR matches
    • Borrow APR matches
  • Select different assets
    • APR updates correctly
    • Values match Blend UI

Key Takeaway

Blend SDK APR Format:

  • ✅ Returns as decimal (0.0732 for 7.32%)
  • ❌ NOT as percentage (7.32)
  • ❌ NOT as basis points (732)

Our Storage Format:

  • Store as basis points (multiply by 10000)
  • Display as percentage (divide by 100)

Conversion Formula:

SDK Decimal → Basis Points: × 10000
Basis Points → Percentage: ÷ 100

Example:
0.0732 × 10000 = 732 bp
732 bp ÷ 100 = 7.32%

Status: ✅ Fixed
Build: ✅ Passing
Accuracy: ✅ Matches Blend UI
Date: October 29, 2024