Merge pull request #1392 from open-circle/improve-test-coverage

Enhance test coverage of library

Author: fabian-hiller

library/src/actions/parseJson/parseJson.test.ts

@@ -151,4 +151,17 @@ describe('parseJson', () => {
       });
     });
   });
+
+  describe('should throw non-Error exceptions', () => {
+    test('for non-Error thrown by reviver', () => {
+      const action = parseJson({
+        reviver: () => {
+          throw 'custom string error';
+        },
+      });
+      expect(() => action['~run']({ typed: true, value: '{}' }, {})).toThrow(
+        'custom string error'
+      );
+    });
+  });
 });

library/src/actions/stringifyJson/stringifyJson.test.ts

@@ -230,4 +230,17 @@ describe('stringifyJson', () => {
       });
     });
   });
+
+  describe('should throw non-Error exceptions', () => {
+    test('for non-Error thrown by replacer', () => {
+      const action = stringifyJson({
+        replacer: () => {
+          throw 'custom string error';
+        },
+      });
+      expect(() =>
+        action['~run']({ typed: true, value: { foo: 'bar' } }, {})
+      ).toThrow('custom string error');
+    });
+  });
 });

library/src/schemas/record/record.test.ts

@@ -65,6 +65,14 @@ describe('record', () => {
     test('for simple record', () => {
       expectNoSchemaIssue(schema, [{ foo: 1, bar: 2, baz: 3 }]);
     });
+
+    test('for record with __proto__ key', () => {
+      const input = JSON.parse('{"__proto__": 123, "foo": 456}');
+      expect(schema['~run']({ value: input }, {})).toStrictEqual({
+        typed: true,
+        value: { foo: 456 },
+      });
+    });
   });
 
   describe('should return dataset with issues', () => {
@@ -202,6 +210,34 @@ describe('record', () => {
       } satisfies FailureDataset<InferIssue<typeof schema>>);
     });
 
+    test('for first key invalid only', () => {
+      const keySchema = record(picklist(['foo', 'bar']), number());
+      const input = { invalid: 1 };
+      expect(keySchema['~run']({ value: input }, {})).toStrictEqual({
+        typed: false,
+        value: {},
+        issues: [
+          {
+            ...baseInfo,
+            kind: 'schema',
+            type: 'picklist',
+            input: 'invalid',
+            expected: '("foo" | "bar")',
+            received: '"invalid"',
+            path: [
+              {
+                type: 'object',
+                origin: 'key',
+                input,
+                key: 'invalid',
+                value: 1,
+              },
+            ],
+          },
+        ],
+      });
+    });
+
     test('with abort early for invalid key', () => {
       const input = {
         foo: 1,

library/src/utils/_getLastMetadata/_getLastMetadata.test.ts

@@ -72,5 +72,14 @@ describe('_getLastMetadata', () => {
         )
       ).toBe('bar');
     });
+
+    test('for nested schema without matching metadata', () => {
+      expect(
+        _getLastMetadata(
+          pipe(pipe(string(), title('found')), pipe(string(), email())),
+          'title'
+        )
+      ).toBe('found');
+    });
   });
 });

library/vitest.config.ts

@@ -14,6 +14,7 @@ export default defineConfig({
         '**/types.ts',
         '**/*.test.ts',
         '**/*.test-d.ts',
+        '**/.DS_Store',
       ],
     },
   },