mark taint timeAdded as optional (#368)

Signed-off-by: Qing Hao <[email protected]>

Author: haoqing0110

cluster/v1/0000_00_clusters.open-cluster-management.io_managedclusters.crd.yaml

@@ -152,7 +152,6 @@ spec:
                   required:
                   - effect
                   - key
-                  - timeAdded
                   type: object
                 type: array
             required:

cluster/v1/types.go

@@ -110,7 +110,7 @@ type Taint struct {
 	Effect TaintEffect `json:"effect"`
 	// TimeAdded represents the time at which the taint was added.
 	// +nullable
-	// +required
+	// +optional
 	TimeAdded metav1.Time `json:"timeAdded"`
 }
 

test/integration/api/managedcluster_test.go

@@ -7,6 +7,7 @@ import (
 	"github.com/onsi/ginkgo"
 	"github.com/onsi/gomega"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/rand"
 	clusterv1 "open-cluster-management.io/api/cluster/v1"
 )
@@ -83,17 +84,26 @@ var _ = ginkgo.Describe("ManagedCluster API test", func() {
 		_, err = hubClusterClient.ClusterV1().ManagedClusters().Update(context.TODO(), cluster, metav1.UpdateOptions{})
 		gomega.Expect(err).To(gomega.HaveOccurred())
 
-		// Effect is not correct
+		// key, value, effect is correct and update
 		cluster.Spec.Taints = []clusterv1.Taint{
 			{
 				Key:    "test.io/test",
 				Value:  "test",
 				Effect: clusterv1.TaintEffectNoSelect,
 			},
 		}
-
 		_, err = hubClusterClient.ClusterV1().ManagedClusters().Update(context.TODO(), cluster, metav1.UpdateOptions{})
 		gomega.Expect(err).ToNot(gomega.HaveOccurred())
 
+		// key, value, effect is correct and patch
+		_, err = hubClusterClient.ClusterV1().ManagedClusters().Patch(
+			context.TODO(),
+			cluster.Name,
+			types.MergePatchType,
+			[]byte(`{"spec":{"taints":[{"key":"test.io/test","value":"testnew","effect":"NoSelect"}]}}`),
+			metav1.PatchOptions{},
+		)
+		gomega.Expect(err).ToNot(gomega.HaveOccurred())
+
 	})
 })