Add --placement-ref flag to addon create command (#513)

This commit adds support for the --placement-ref flag to the
addon create command, allowing users to specify a Placement
resource reference for automatic addon installation.

Changes:
- Add PlacementRef field to Options struct
- Add --placement-ref flag accepting namespace/name format
- Implement parsePlacementRef() to parse and validate the flag value
- Update newClusterManagementAddon() to set InstallStrategy based on flag
  - Manual strategy when flag is not provided (default behavior)
  - Placements strategy when flag is provided
- Add validation for placement-ref format
- Add comprehensive test coverage with 12 test cases including:
  - Unit tests for parsePlacementRef()
  - Unit tests for newClusterManagementAddon()
  - Integration tests for end-to-end functionality

Fixes #505

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Jian Qiu <[email protected]>
Co-authored-by: Claude <[email protected]>

Author: qiujian16

pkg/cmd/addon/create/cmd.go

@@ -52,6 +52,7 @@ func NewCmd(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, stream
 	cmd.Flags().StringVar(&o.ClusterRoleBindingRef, "cluster-role-bind", "", "The rolebinding to the clusterrole in "+
 		"the cluster namespace for the addon agent")
 	cmd.Flags().StringSliceVar(&o.Labels, "labels", []string{}, "Labels to add to the ClusterManagementAddOn and AddOnTemplate resources (eg. key1=value1,key2=value2)")
+	cmd.Flags().StringVar(&o.PlacementRef, "placement-ref", "", "The namespace/name reference to a Placement resource for automatic addon installation (eg. namespace/placement-name)")
 	o.FileNameFlags.AddFlags(cmd.Flags())
 
 	return cmd

pkg/cmd/addon/create/exec.go

@@ -4,6 +4,7 @@ package create
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/spf13/cobra"
 	"k8s.io/apimachinery/pkg/api/errors"
@@ -76,6 +77,29 @@ func newClusterManagementAddon(o *Options) (*addonv1alpha1.ClusterManagementAddO
 		return nil, err
 	}
 
+	// Parse placement reference
+	placementNamespace, placementName, err := o.parsePlacementRef()
+	if err != nil {
+		return nil, err
+	}
+
+	installStrategy := addonv1alpha1.InstallStrategy{
+		Type: addonv1alpha1.AddonInstallStrategyManual,
+	}
+
+	// If placement-ref is provided, change install strategy to Placements
+	if placementNamespace != "" && placementName != "" {
+		installStrategy.Type = addonv1alpha1.AddonInstallStrategyPlacements
+		installStrategy.Placements = []addonv1alpha1.PlacementStrategy{
+			{
+				PlacementRef: addonv1alpha1.PlacementRef{
+					Namespace: placementNamespace,
+					Name:      placementName,
+				},
+			},
+		}
+	}
+
 	cma := &addonv1alpha1.ClusterManagementAddOn{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:   o.Name,
@@ -96,9 +120,7 @@ func newClusterManagementAddon(o *Options) (*addonv1alpha1.ClusterManagementAddO
 					},
 				},
 			},
-			InstallStrategy: addonv1alpha1.InstallStrategy{
-				Type: addonv1alpha1.AddonInstallStrategyManual,
-			},
+			InstallStrategy: installStrategy,
 		},
 	}
 
@@ -133,6 +155,14 @@ func (o *Options) Validate() (err error) {
 		return fmt.Errorf("manifest files must be specified")
 	}
 
+	// Validate placement-ref format if provided
+	if o.PlacementRef != "" {
+		_, _, err := o.parsePlacementRef()
+		if err != nil {
+			return err
+		}
+	}
+
 	return nil
 }
 
@@ -249,3 +279,24 @@ func (o *Options) readManifests() ([]workapiv1.Manifest, error) {
 func (o *Options) parseLabels() (map[string]string, error) {
 	return parse.ParseLabels(o.Labels)
 }
+
+// parsePlacementRef parses the placement-ref flag and returns namespace and name
+func (o *Options) parsePlacementRef() (namespace, name string, err error) {
+	if o.PlacementRef == "" {
+		return "", "", nil
+	}
+
+	parts := strings.Split(o.PlacementRef, "/")
+	if len(parts) != 2 {
+		return "", "", fmt.Errorf("placement-ref must be in the format 'namespace/name'")
+	}
+
+	namespace = strings.TrimSpace(parts[0])
+	name = strings.TrimSpace(parts[1])
+
+	if namespace == "" || name == "" {
+		return "", "", fmt.Errorf("placement-ref namespace and name cannot be empty")
+	}
+
+	return namespace, name, nil
+}