Treat missing and empty annotations as equivalent

While testing https://issues.redhat.com/browse/ACM-14577 , some objects
reported missing annotations as an empty map while other objects omitted the
annotations key. Handle empty annotations before comparing objects.

Signed-off-by: Janelle Law <[email protected]>

Author: jan-law

controllers/configurationpolicy_controller.go

@@ -3575,6 +3575,10 @@ func removeFieldsForComparison(obj *unstructured.Unstructured) {
 	)
 	// The generation might actually bump but the API output might be the same.
 	unstructured.RemoveNestedField(obj.Object, "metadata", "generation")
+
+	if len(obj.GetAnnotations()) == 0 {
+		unstructured.RemoveNestedField(obj.Object, "metadata", "annotations")
+	}
 }
 
 // setEvaluatedObject updates the cache to indicate that the ConfigurationPolicy has evaluated this

test/resources/case8_status_check/case8_service.yaml

@@ -3,8 +3,6 @@ kind: Service
 metadata:
   name: grc-policy-propagator-metrics
   namespace: managed
-  annotations:
-    test: test
 spec:
   internalTrafficPolicy: Cluster
   ipFamilies: