wip: comment out test expecting openshift admission controller to be present

Signed-off-by: Janelle Law <[email protected]>

Author: jan-law

test/e2e/case40_recreate_option_test.go

@@ -244,72 +244,73 @@ var _ = Describe("Recreate options", Ordered, func() {
 		deleteConfigPolicies([]string{"case40"})
 	})
 
-	It("should set dryRunNoOpOverride to true when SCC annotation is corrected by admission controllers", func() {
-		By("Creating a Pod that will have a valid SCC annotation assigned by OpenShift")
-		utils.Kubectl("apply", "-f", podInvalidSCCYAML)
-
-		By("Waiting for the Pod to have a valid SCC annotation assigned")
-		Eventually(func() string {
-			pod := utils.GetWithTimeout(clientManagedDynamic, gvrPod,
-				"test-pod-scc-case40", "default", true, defaultTimeoutSeconds)
-			sccAnnotation, exists, _ := unstructured.NestedString(
-				pod.Object, "metadata", "annotations", "openshift.io/scc")
-			if !exists {
-				return ""
-			}
-
-			return sccAnnotation
-		}, defaultTimeoutSeconds, 1).ShouldNot(BeEmpty())
-
-		By("Creating a policy that expects the Pod to have an invalid SCC annotation")
-		utils.Kubectl("apply", "-f", policyPodInvalidSCCYAML, "-n", testNamespace)
-
-		By("Verifying the policy becomes compliant despite the SCC mismatch")
-		Eventually(func(g Gomega) {
-			managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
-				"policy-pod-invalid-scc-case40", testNamespace, true, defaultTimeoutSeconds)
-
-			utils.CheckComplianceStatus(g, managedPlc, "Compliant")
-		}, defaultTimeoutSeconds, 1).Should(Succeed())
-
-		By("Verifying dryRunNoOpOverride is true due to OpenShift SCC annotation correction")
-		Eventually(func() bool {
-			managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
-				"policy-pod-invalid-scc-case40", testNamespace, true, defaultTimeoutSeconds)
-			relatedObj := managedPlc.Object["status"].(map[string]interface{})["relatedObjects"].([]interface{})[0]
-			properties, exists := relatedObj.(map[string]interface{})["properties"]
-			if !exists {
-				return false
-			}
-
-			propertiesMap := properties.(map[string]interface{})
-			if dryRunNoOpOverride, exists := propertiesMap["dryRunNoOpOverride"]; exists {
-				return dryRunNoOpOverride.(bool)
-			}
-
-			return false
-		}, defaultTimeoutSeconds, 1).Should(BeTrue())
-
-		By("Verifying createdByPolicy is true for the recreated Pod")
-		Eventually(func() bool {
-			managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
-				"policy-pod-invalid-scc-case40", testNamespace, true, defaultTimeoutSeconds)
-			relatedObj := managedPlc.Object["status"].(map[string]interface{})["relatedObjects"].([]interface{})[0]
-			properties, exists := relatedObj.(map[string]interface{})["properties"]
-			if !exists {
-				return false
-			}
-
-			propertiesMap := properties.(map[string]interface{})
-			if createdByPolicy, exists := propertiesMap["createdByPolicy"]; exists {
-				return createdByPolicy.(bool)
-			}
-
-			return false
-		}, defaultTimeoutSeconds, 1).Should(BeTrue())
-
-		By("Cleaning up the test resources")
-		utils.KubectlDelete("configurationpolicy", "policy-pod-invalid-scc-case40", "-n", testNamespace)
-		utils.KubectlDelete("pod", "test-pod-scc-case40", "-n", "default")
-	})
+	// how to test this?
+	// It("should set dryRunNoOpOverride to true when SCC annotation is corrected by admission controllers", func() {
+	// 	By("Creating a Pod that will have a valid SCC annotation assigned by OpenShift")
+	// 	utils.Kubectl("apply", "-f", podInvalidSCCYAML)
+
+	// 	By("Waiting for the Pod to have a valid SCC annotation assigned")
+	// 	Eventually(func() string {
+	// 		pod := utils.GetWithTimeout(clientManagedDynamic, gvrPod,
+	// 			"test-pod-scc-case40", "default", true, defaultTimeoutSeconds)
+	// 		sccAnnotation, exists, _ := unstructured.NestedString(
+	// 			pod.Object, "metadata", "annotations", "openshift.io/scc")
+	// 		if !exists {
+	// 			return ""
+	// 		}
+
+	// 		return sccAnnotation
+	// 	}, defaultTimeoutSeconds, 1).ShouldNot(BeEmpty())
+
+	// 	By("Creating a policy that expects the Pod to have an invalid SCC annotation")
+	// 	utils.Kubectl("apply", "-f", policyPodInvalidSCCYAML, "-n", testNamespace)
+
+	// 	By("Verifying the policy becomes compliant despite the SCC mismatch")
+	// 	Eventually(func(g Gomega) {
+	// 		managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
+	// 			"policy-pod-invalid-scc-case40", testNamespace, true, defaultTimeoutSeconds)
+
+	// 		utils.CheckComplianceStatus(g, managedPlc, "Compliant")
+	// 	}, defaultTimeoutSeconds, 1).Should(Succeed())
+
+	// 	By("Verifying dryRunNoOpOverride is true due to OpenShift SCC annotation correction")
+	// 	Eventually(func() bool {
+	// 		managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
+	// 			"policy-pod-invalid-scc-case40", testNamespace, true, defaultTimeoutSeconds)
+	// 		relatedObj := managedPlc.Object["status"].(map[string]interface{})["relatedObjects"].([]interface{})[0]
+	// 		properties, exists := relatedObj.(map[string]interface{})["properties"]
+	// 		if !exists {
+	// 			return false
+	// 		}
+
+	// 		propertiesMap := properties.(map[string]interface{})
+	// 		if dryRunNoOpOverride, exists := propertiesMap["dryRunNoOpOverride"]; exists {
+	// 			return dryRunNoOpOverride.(bool)
+	// 		}
+
+	// 		return false
+	// 	}, defaultTimeoutSeconds, 1).Should(BeTrue())
+
+	// 	By("Verifying createdByPolicy is true for the recreated Pod")
+	// 	Eventually(func() bool {
+	// 		managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
+	// 			"policy-pod-invalid-scc-case40", testNamespace, true, defaultTimeoutSeconds)
+	// 		relatedObj := managedPlc.Object["status"].(map[string]interface{})["relatedObjects"].([]interface{})[0]
+	// 		properties, exists := relatedObj.(map[string]interface{})["properties"]
+	// 		if !exists {
+	// 			return false
+	// 		}
+
+	// 		propertiesMap := properties.(map[string]interface{})
+	// 		if createdByPolicy, exists := propertiesMap["createdByPolicy"]; exists {
+	// 			return createdByPolicy.(bool)
+	// 		}
+
+	// 		return false
+	// 	}, defaultTimeoutSeconds, 1).Should(BeTrue())
+
+	// 	By("Cleaning up the test resources")
+	// 	utils.KubectlDelete("configurationpolicy", "policy-pod-invalid-scc-case40", "-n", testNamespace)
+	// 	utils.KubectlDelete("pod", "test-pod-scc-case40", "-n", "default")
+	// })
 })