Skip to content

Commit 817edab

Browse files
committed
fixup! test: document remaining test failures
Signed-off-by: Janelle Law <[email protected]>
1 parent dcffe03 commit 817edab

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

pkg/dryrun/dryrun.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,7 @@ func (d *DryRunner) setupReconciler(
452452
var nsSelReconciler common.NamespaceSelectorReconciler
453453

454454
if d.fromCluster {
455+
// Point target clients to real cluster
455456
loadingRules := clientcmd.NewDefaultClientConfigLoadingRules()
456457
clientConfig := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(
457458
loadingRules, &clientcmd.ConfigOverrides{},

test/dryrun/obj_tmpl_raw/invalid_yaml/err_from_cluster.txt

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/e2e/case46_dryrun_cli_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
6666
Describe("Context Variables Tests", func() {
6767
testContextVariables := map[string]string{
6868
"object_cluster_scoped": "Test Object: available for cluster-scoped objects",
69-
// "object_namespaced": "Test Object: available for namespaced objects",
70-
// FIXME err executing "tmpl" at <"inventory.yaml">: invalid value; expected string
69+
"object_namespaced": "Test Object: available for namespaced objects",
70+
// FIXME err executing "tmpl" at <"inventory.yaml">: invalid value; expected string -> fails when applying template to kube root ca crt
7171
"object_pod": "Test Object: available for complex objects",
7272
"object_pod_default_func": "Test Object: nil but succeeds with default function",
7373
"object_pod_nsselector": "Test Object: nil for objects that don't exist",
@@ -90,7 +90,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
9090

9191
Describe("Diff Tests", func() {
9292
testDiff := map[string]string{
93-
// "truncated": "Diff is truncated",
93+
"truncated": "Diff is truncated",
9494
// FIXME got: relatedObjects does not match + showing 50/68 diff lines + @@ -1,8 +1,64 @@ -> want: relatedObjects matches + showing 50/65 diff lines + @@ -1,5 +1,61 @@
9595
"secret_obj_temp": "No diff when configuring a Secret",
9696
"from_secret_obj_temp_raw": "No diff when using fromSecret (object-templates-raw)",
@@ -217,9 +217,8 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
217217

218218
Describe("Object Template Raw Tests", func() {
219219
testObjTmplRaw := map[string]string{
220-
// "invalid_yaml": "Test noncompliant with invalid YAML in object-templates-raw",
221-
// FIXME got: policy is NonCompliant -> want: unable to read input resources: failed to parse object-templates-raw: error converting YAML to JSON: yaml: unknown anchor 'odd' referenced
222-
"range": "Test compliant with range in object-templates-raw",
220+
"invalid_yaml": "Test noncompliant with invalid YAML in object-templates-raw",
221+
"range": "Test compliant with range in object-templates-raw",
223222
}
224223

225224
It("Should handle object template raw", func() {

0 commit comments

Comments
 (0)