fixup: comment remaining test failures

Signed-off-by: Janelle Law <[email protected]>

Author: jan-law

test/dryrun/obj_tmpl_raw/invalid_yaml/err_from_cluster.txt

@@ -1,2 +1,3 @@
- Error: unable to read input resources: failed to parse object-templates-raw: yaml: unknown anchor 'odd' referenced
- 
+Error:
+unable to read input resources:
+failed to parse object-templates-raw: error converting YAML to JSON: yaml: unknown anchor 'odd' referenced

test/e2e/case46_dryrun_cli_test.go

@@ -68,14 +68,13 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 			"object_cluster_scoped": "Test Object: available for cluster-scoped objects",
 			// "object_namespaced": "Test Object: available for namespaced objects",
 			// FIXME executing "tmpl" at <"inventory.yaml">: invalid value; expected string. not all maps in cluster have .data
-			"object_pod": "Test Object: available for complex objects",
-			// "object_pod_default_func": "Test Object: nil but succeeds with default function",
-			// FIXME default pod created successfully in fake cluster, but missing message: pods [nginx-pod] not found in namespace dangler;
-			"object_pod_nsselector": "Test Object: nil for objects that don't exist",
-			"object_templated_ns":   "Test Object: nil when namespace is templated",
-			"object_unnamed_objdef": "Test Object: unavailable for unnamed objects",
+			"object_pod":              "Test Object: available for complex objects",
+			"object_pod_default_func": "Test Object: nil but succeeds with default function",
+			"object_pod_nsselector":   "Test Object: nil for objects that don't exist",
+			"object_templated_ns":     "Test Object: nil when namespace is templated",
+			"object_unnamed_objdef":   "Test Object: unavailable for unnamed objects",
 			// "objectname_nsselector": "Test ObjectName: correctly handle namespaceSelector",
-			// FIXME config maps created in fake cluster, but got: No objects of kind ConfigMap were matched from the policy objectSelector
+			// FIXME want: @@ -1,7 +1,8 @@\n apiVersion: v1\n-data: {}\n+data:\n+  hocus: pocus\n -> got: @@ -1,6 +1,8 @@\n apiVersion: v1\n+data:\n+  hocus: pocus\n
 			"objectns_cluster_scoped":          "Test ObjectNamespace: unavailable for cluster-scoped objects",
 			"objectns_templated_empty":         "Test ObjectNamespace: noncompliant for empty templated namespace",
 			"objectns_templated_no_nsselector": "Test ObjectNamespace: available for templated namespace",
@@ -84,7 +83,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 		It("Should handle context variables", func() {
 			for testDir, testName := range testContextVariables {
 
-				By("Testing context variables" + testName)
+				By("Testing context variables " + testName)
 				testDryrunScenario("context_vars", testDir, testName)
 			}
 		})
@@ -102,7 +101,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 
 		It("Should handle diffs", func() {
 			for testDir, testName := range testDiff {
-				By("Testing diff" + testName)
+				By("Testing diff " + testName)
 				testDryrunScenario("diff", testDir, testName)
 			}
 		})
@@ -116,7 +115,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 
 		It("Should handle pod annotations", func() {
 			for testDir, testName := range testKindField {
-				By("Testing pod annotations" + testName)
+				By("Testing pod annotations " + testName)
 				testDryrunScenario("kind_field", testDir, testName)
 			}
 		})
@@ -125,33 +124,29 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 	Describe("Missing Field Tests", func() {
 		testMissing := map[string]string{
 			"missing_kind_name": "Test Missing kind and name",
-			// "missing_name": "Test Missing name",
-			// FIXME want: pods not found in namespaces: n1, n2, n3, got: namespaced object case5-multi-namespace-inform-pod of kind Pod has no namespace specified from the policy namespaceSelector nor the object metadata
-			"missing_kind": "Test Missing kind",
+			"missing_name":      "Test Missing name",
+			"missing_kind":      "Test Missing kind",
 		}
 
 		It("Should handle missing fields", func() {
 			for testDir, testName := range testMissing {
-				By("Testing missing fields" + testName)
+				By("Testing missing fields " + testName)
 				testDryrunScenario("missing", testDir, testName)
 			}
 		})
 	})
 
 	Describe("Multiple Object Tests", func() {
 		testMultiple := map[string]string{
-			"multiple_mustnothave": "Test multiple object combo",
-			"multiple_obj_combo":   "Test multiple object combo",
-			// "multiple_namespace_inform":  "Test multiple namespace inform",
-			// FIXME want: pods [case5-multi-namespace-inform-pod] not found in namespaces: n1, n2, n3\n, got:  namespaced object case5-multi-namespace-inform-pod of kind Pod has no namespace specified from the policy namespaceSelector nor the object metadata
-			// "multiple_namespace_enforce": "Test multiple namespace enforce",
-			// FIXME want: found as specified, got: namespaced object has no ns specified from policy ns sel nor metadata
-			// "multiple_obj_template":      "Test multiple object template",
-			// FIXME (same as above) want: found as specified, got: namespaced object has no ns specified from policy ns sel nor metadata
+			"multiple_mustnothave":       "Test multiple object combo",
+			"multiple_obj_combo":         "Test multiple object combo",
+			"multiple_namespace_inform":  "Test multiple namespace inform",
+			"multiple_namespace_enforce": "Test multiple namespace enforce",
+			"multiple_obj_template":      "Test multiple object template",
 		}
 		It("Should handle multiple objects", func() {
 			for testDir, testName := range testMultiple {
-				By("Testing multiple objects" + testName)
+				By("Testing multiple objects " + testName)
 				testDryrunScenario("multiple", testDir, testName)
 			}
 		})
@@ -168,7 +163,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 
 		It("Should handle no name objects", func() {
 			for testDir, testName := range testNoName {
-				By("Testing no name objects" + testName)
+				By("Testing no name objects " + testName)
 				testDryrunScenario("no_name", testDir, testName)
 			}
 		})
@@ -181,7 +176,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 		}
 		It("Should handle cluster-scoped no name", func() {
 			for testDir, testName := range testNoNameCluster {
-				By("Testing cluster-scoped no name" + testName)
+				By("Testing cluster-scoped no name " + testName)
 				testDryrunScenario("no_name_clusterscope", testDir, testName)
 			}
 		})
@@ -196,7 +191,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 
 		It("Should handle no namespace", func() {
 			for testDir, testName := range testNoNs {
-				By("Testing no namespace" + testName)
+				By("Testing no namespace " + testName)
 				testDryrunScenario("no_ns", testDir, testName)
 			}
 		})
@@ -216,7 +211,7 @@ var _ = Describe("Testing dryrun CLI", Ordered, func() {
 
 		It("Should handle object template raw", func() {
 			for testDir, testName := range testObjTmplRaw {
-				By("Testing object template raw" + testName)
+				By("Testing object template raw " + testName)
 				testDryrunScenario("obj_tmpl_raw", testDir, testName)
 			}
 		})
@@ -229,7 +224,7 @@ func testDryrunScenario(testCategory, testDir, testName string) {
 
 	inputFiles := findInputFiles(testPath)
 	for _, inputFile := range inputFiles {
-		By("Applying input file" + inputFile)
+		By("Applying input file " + inputFile)
 
 		utils.Kubectl("apply", "-f", inputFile)
 	}