Skip to content

Commit 14c2ce3

Browse files
JustinKuliopenshift-merge-robot
authored andcommitted
Log more info about dependency errors
Previously only the GVK of the dependency with the error were logged. That made it difficult sometimes to know which thing failed. Signed-off-by: Justin Kulikauskas <[email protected]>
1 parent 02138c7 commit 14c2ce3

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

controllers/templatesync/template_sync.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -507,11 +507,7 @@ func (r *PolicyReconciler) processDependencies(ctx context.Context, dClient dyna
507507
if depMapping != nil {
508508
rsrc = depMapping.Resource
509509
} else {
510-
tLogger.Error(err, "Could not find an API mapping for the dependency",
511-
"group", depGvk.Group,
512-
"version", depGvk.Version,
513-
"kind", depGvk.Kind,
514-
)
510+
tLogger.Error(err, "Could not find an API mapping for the dependency", "object", dep)
515511

516512
dependencyFailures = append(dependencyFailures, dep)
517513

@@ -529,17 +525,17 @@ func (r *PolicyReconciler) processDependencies(ctx context.Context, dClient dyna
529525

530526
depObj, err := res.Get(ctx, dep.Name, metav1.GetOptions{})
531527
if err != nil {
532-
tLogger.Info("Failed to get dependency object", "object", depGvk)
528+
tLogger.Info("Failed to get dependency object", "object", dep)
533529

534530
dependencyFailures = append(dependencyFailures, dep)
535531
} else {
536532
depCompliance, found, err := unstructured.NestedString(depObj.Object, "status", "compliant")
537533
if err != nil || !found {
538-
tLogger.Info("Failed to get compliance for dependency object", "object", depGvk)
534+
tLogger.Info("Failed to get compliance for dependency object", "object", dep)
539535

540536
dependencyFailures = append(dependencyFailures, dep)
541537
} else if depCompliance != templateDeps[dep] {
542-
tLogger.Info("Compliance mismatch for dependency object", "object", depGvk)
538+
tLogger.Info("Compliance mismatch for dependency object", "object", dep)
543539

544540
dependencyFailures = append(dependencyFailures, dep)
545541
}

0 commit comments

Comments
 (0)