Fix test assertion for duplicate events

The test is meant to ensure that the gatekeeper-sync is not emitting the
same event multiple times in a row. But the assertion was failing
sometimes because of duplicate events from template-errors. Those will
sometimes occur during normal (correct) operation of the template-sync.

Signed-off-by: Justin Kulikauskas <[email protected]>

Author: JustinKuli

test/e2e/case17_gatekeeper_sync_test.go

@@ -297,9 +297,9 @@ var _ = Describe("Test Gatekeeper ConstraintTemplate and constraint sync", Order
 				fmt.Sprintf("Got %s but expected one of %v", history[0].Message, validMsgs),
 			)
 
-			// Verify that there are no duplicate status messages.
+			// Verify that there are no duplicate gatekeeper status messages.
 			for i, historyEvent := range managedPolicy.Status.Details[1].History {
-				if i == 0 || strings.HasPrefix(historyEvent.Message, "NonCompliant; template-error;") {
+				if i == 0 || strings.Contains(historyEvent.Message, "NonCompliant; template-error;") {
 					continue
 				}