Handle the default value for recreateOption

Relates:
https://issues.redhat.com/browse/ACM-11846

Signed-off-by: mprahl <[email protected]>

Author: mprahl

controllers/templatesync/template_sync.go

@@ -961,7 +961,31 @@ func equivalentTemplates(eObject *unstructured.Unstructured, tObject *unstructur
 		if pruneObjectBehavior == "" {
 			err := unstructured.SetNestedField(tObject.Object, "None", "spec", "pruneObjectBehavior")
 			if err != nil {
-				log.Error(err, "Failed to set the default value of pruneObjectBehavior for")
+				log.Error(err, "Failed to set the default value of pruneObjectBehavior")
+			}
+		}
+
+		var updatedObjectTemplates bool
+
+		objectTemplates, _, _ := unstructured.NestedSlice(tObject.Object, "spec", "object-templates")
+
+		for i := range objectTemplates {
+			objectTemplate, ok := objectTemplates[i].(map[string]interface{})
+			if !ok {
+				continue
+			}
+
+			if _, ok := objectTemplate["recreateOption"]; !ok {
+				objectTemplate["recreateOption"] = "None"
+				objectTemplates[i] = objectTemplate
+				updatedObjectTemplates = true
+			}
+		}
+
+		if updatedObjectTemplates {
+			err := unstructured.SetNestedField(tObject.Object, objectTemplates, "spec", "object-templates")
+			if err != nil {
+				log.Error(err, "Failed to set the default value of recreateOption")
 			}
 		}
 	}

controllers/templatesync/template_sync_test.go

@@ -213,3 +213,63 @@ func TestGetDupName(t *testing.T) {
 		t.Fatal("Duplicate name not detected")
 	}
 }
+
+func TestEquivalentTemplatesRecreateOption(t *testing.T) {
+	existing := &unstructured.Unstructured{
+		Object: map[string]interface{}{
+			"apiVersion": "policy.open-cluster-management.io/v1",
+			"kind":       "ConfigurationPolicy",
+			"metadata": map[string]interface{}{
+				"name":      "my-policy",
+				"namespace": "local-cluster",
+			},
+			"spec": map[string]interface{}{
+				"pruneObjectBehavior": "None",
+				"object-templates": []interface{}{
+					map[string]interface{}{
+						"complianceType": "musthave",
+						"recreateOption": "None",
+						"objectDefinition": map[string]interface{}{
+							"apiVersion": "v1",
+							"kind":       "Pod",
+							"metadata": map[string]interface{}{
+								"name":      "nginx-pod-e2e",
+								"namespace": "default",
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+
+	template := &unstructured.Unstructured{
+		Object: map[string]interface{}{
+			"apiVersion": "policy.open-cluster-management.io/v1",
+			"kind":       "ConfigurationPolicy",
+			"metadata": map[string]interface{}{
+				"name":      "my-policy",
+				"namespace": "local-cluster",
+			},
+			"spec": map[string]interface{}{
+				"object-templates": []interface{}{
+					map[string]interface{}{
+						"complianceType": "musthave",
+						"objectDefinition": map[string]interface{}{
+							"apiVersion": "v1",
+							"kind":       "Pod",
+							"metadata": map[string]interface{}{
+								"name":      "nginx-pod-e2e",
+								"namespace": "default",
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+
+	if !equivalentTemplates(existing, template) {
+		t.Fatal("Expected the templates to be equivalent")
+	}
+}