🐛 fix fleetconfig-system namespace typo, catch image/release tag mismatches in CI (#20)

* fix: typo in smoketests; remove ns overrides from devspace.yaml
* ci: bump image tag & update CI to catch mismatches
* fix: prevent globbing, word-splitting
* chore: make reviewable
---------

Signed-off-by: Tyler Gillson <[email protected]>

Author: TylerGillson

.github/workflows/release.yml

@@ -80,6 +80,15 @@ jobs:
           set -e
           mkdir -p release
           pushd release
+
+          # assert that the default image tag in values.yaml matches the release version
+          chartImageTag=$(yq eval '.image.tag' ../${{ matrix.repository }}/charts/${{ matrix.repository }}/values.yaml)
+          if [[ "$chartImageTag" != "${{ needs.env.outputs.RELEASE_VERSION }}" && "$chartImageTag" != "${{ needs.env.outputs.TRIMMED_RELEASE_VERSION }}" ]]; then
+            echo "Error: .image.tag in values.yaml ($chartImageTag) does not match the release version (${{ needs.env.outputs.RELEASE_VERSION }}) or the trimmed release version (${{ needs.env.outputs.TRIMMED_RELEASE_VERSION }})"
+            exit 1
+          fi
+
+          # stage helm dependencies and package the chart
           yq eval '.dependencies[] | .name + " " + .repository' ../${{ matrix.repository }}/charts/${{ matrix.repository }}/Chart.yaml | while read -r repo_name repo_url; do
             if [[ ! "$repo_url" =~ ^(oci://|file://) ]]; then
               helm repo add "$repo_name" "$repo_url"
@@ -92,6 +101,7 @@ jobs:
           helm package ../${{ matrix.repository }}/charts/${{ matrix.repository }} \
             --app-version ${{ needs.env.outputs.RELEASE_VERSION }} \
             --version ${{ needs.env.outputs.TRIMMED_RELEASE_VERSION }}
+
           popd
 
       - name: publish release

fleetconfig-controller/charts/fleetconfig-controller/README.md

@@ -105,7 +105,7 @@ Refer to the [Multicluster Controlplane configuration](https://github.com/open-c
 | `replicas`                                          | fleetconfig-controller replica count                                                                                           | `1`                                                      |
 | `imageRegistry`                                     | Image registry                                                                                                                 | `""`                                                     |
 | `image.repository`                                  | Image repository                                                                                                               | `quay.io/open-cluster-management/fleetconfig-controller` |
-| `image.tag`                                         | x-release-please-version                                                                                                       | `v0.0.1`                                                 |
+| `image.tag`                                         | Image tag                                                                                                                      | `v0.0.2`                                                 |
 | `image.pullPolicy`                                  | Image pull policy                                                                                                              | `IfNotPresent`                                           |
 | `imagePullSecrets`                                  | Image pull secrets                                                                                                             | `[]`                                                     |
 | `serviceAccount.annotations`                        | Annotations to add to the service account                                                                                      | `{}`                                                     |

fleetconfig-controller/charts/fleetconfig-controller/values.yaml

@@ -237,11 +237,11 @@ replicas: 1
 imageRegistry: ""
 
 ## @param image.repository Image repository
-## @param image.tag x-release-please-version
+## @param image.tag Image tag
 ## @param image.pullPolicy Image pull policy
 image:
   repository: quay.io/open-cluster-management/fleetconfig-controller
-  tag: v0.0.1  # x-release-please-version
+  tag: v0.0.2
   pullPolicy: IfNotPresent
 
 ## @param imagePullSecrets Image pull secrets

fleetconfig-controller/devspace.yaml

@@ -71,7 +71,6 @@ images:
 
 deployments:
   fleetconfig-controller:
-    namespace: fleetconfig-system
     helm:
       chart:
         name: ${CONTEXT}/charts/fleetconfig-controller
@@ -84,7 +83,6 @@ deployments:
     updateImageTags: false
 
   fleetconfig-controller-dev:
-    namespace: fleetconfig-system
     helm:
       chart:
         name: ${CONTEXT}/charts/fleetconfig-controller
@@ -94,7 +92,6 @@ deployments:
       - ${CONTEXT}/charts/fleetconfig-controller/values.yaml
 
   fleetconfig-controller-local:
-    namespace: fleetconfig-system
     helm:
       chart:
         name: ${CONTEXT}/charts/fleetconfig-controller

fleetconfig-controller/docs/smoketests.md

@@ -67,7 +67,7 @@ mkdir -p $TARGET_DIR
 1. Install the `fleetconfig-controller` on the hub using the `deploy-local` pipeline
 
    ```bash
-   devspace run-pipeline deploy-local -n fleet-config-system --skip-build
+   devspace run-pipeline deploy-local -n fleetconfig-system --skip-build
    ```
 
 1. Verify that the `FleetConfig` is reconciled successfully