fix: only set addonconfigured condition when num addons > 0 (#38)

* fix: only set addonconfigured condition when num addons > 0

Signed-off-by: Artur Shad Nik <[email protected]>

* chore: bump version

Signed-off-by: Artur Shad Nik <[email protected]>

---------

Signed-off-by: Artur Shad Nik <[email protected]>

Author: arturshadnik

fleetconfig-controller/charts/fleetconfig-controller/README.md

@@ -115,7 +115,7 @@ Refer to the [Multicluster Controlplane configuration](https://github.com/open-c
 | `replicas`                                          | fleetconfig-controller replica count                                                                                                   | `1`                                                      |
 | `imageRegistry`                                     | Image registry                                                                                                                         | `""`                                                     |
 | `image.repository`                                  | Image repository                                                                                                                       | `quay.io/open-cluster-management/fleetconfig-controller` |
-| `image.tag`                                         | Image tag                                                                                                                              | `v0.0.8`                                                 |
+| `image.tag`                                         | Image tag                                                                                                                              | `v0.0.9`                                                 |
 | `image.pullPolicy`                                  | Image pull policy                                                                                                                      | `IfNotPresent`                                           |
 | `imagePullSecrets`                                  | Image pull secrets                                                                                                                     | `[]`                                                     |
 | `serviceAccount.annotations`                        | Annotations to add to the service account                                                                                              | `{}`                                                     |

fleetconfig-controller/charts/fleetconfig-controller/values.yaml

@@ -277,7 +277,7 @@ imageRegistry: ""
 ## @param image.pullPolicy Image pull policy
 image:
   repository: quay.io/open-cluster-management/fleetconfig-controller
-  tag: v0.0.8
+  tag: v0.0.9
   pullPolicy: IfNotPresent
 
 ## @param imagePullSecrets Image pull secrets

fleetconfig-controller/internal/controller/hub.go

@@ -94,9 +94,11 @@ func handleHub(ctx context.Context, kClient client.Client, fc *v1alpha1.FleetCon
 		return err
 	}
 
-	fc.SetConditions(true, v1alpha1.NewCondition(
-		v1alpha1.FleetConfigAddonsConfigured, v1alpha1.FleetConfigAddonsConfigured, metav1.ConditionTrue, metav1.ConditionTrue,
-	))
+	if len(fc.Spec.AddOnConfigs) > 0 {
+		fc.SetConditions(true, v1alpha1.NewCondition(
+			v1alpha1.FleetConfigAddonsConfigured, v1alpha1.FleetConfigAddonsConfigured, metav1.ConditionTrue, metav1.ConditionTrue,
+		))
+	}
 	// attempt an upgrade whenever the clustermanager's bundleVersion changes
 	upgrade, err := hubNeedsUpgrade(ctx, fc, operatorC)
 	if err != nil {