Add validate policyNS + policyName must be not more than 63 chars (#26)

Signed-off-by: melserngawy <[email protected]>

Author: serngawy

internal/plugin.go

@@ -22,6 +22,7 @@ const (
 	placementBindingKind       = "PlacementBinding"
 	placementRuleAPIVersion    = "apps.open-cluster-management.io/v1"
 	placementRuleKind          = "PlacementRule"
+	maxObjectNameLength        = 63
 )
 
 // Plugin is used to store the PolicyGenerator configuration and the methods to generate the
@@ -358,6 +359,11 @@ func (p *Plugin) assertValidConfig() error {
 			return errors.New("each policy must have a name set")
 		}
 
+		if len(p.PolicyDefaults.Namespace+"."+policy.Name) > maxObjectNameLength {
+			return fmt.Errorf("the policy namespace and name cannot be more than 63 characters %s.%s",
+				p.PolicyDefaults.Namespace, policy.Name)
+		}
+
 		if seen[policy.Name] {
 			return fmt.Errorf("each policy must have a unique name set: %s", policy.Name)
 		}

internal/plugin_config_test.go

@@ -223,6 +223,39 @@ policies:
 	assertEqual(t, err.Error(), expected)
 }
 
+func TestCreateInvalidPolicyName(t *testing.T) {
+	t.Parallel()
+	tmpDir := t.TempDir()
+	createConfigMap(t, tmpDir, "configmap.yaml")
+	configMapPath := path.Join(tmpDir, "configmap.yaml")
+	policyNS := "my-policies-my-policies-my-policies"
+	policyName := "policy-app-config-policy-app-config-policy-app-config"
+	defaultsConfig := fmt.Sprintf(
+		`
+apiVersion: policy.open-cluster-management.io/v1
+kind: PolicyGenerator
+metadata:
+  name: policy-generator-name
+policyDefaults:
+  namespace: %s
+policies:
+- name: %s
+  manifests:
+    - path: %s
+`,
+		policyNS, policyName, configMapPath,
+	)
+
+	p := Plugin{}
+	err := p.Config([]byte(defaultsConfig))
+	if err == nil {
+		t.Fatal("Expected an error but did not get one")
+	}
+
+	expected := fmt.Sprintf("the policy namespace and name cannot be more than 63 characters %s.%s", policyNS, policyName)
+	assertEqual(t, err.Error(), expected)
+}
+
 func TestConfigNoPolicies(t *testing.T) {
 	t.Parallel()
 	const config = `