Only set the dependency namespace for Policy

IamPolicy, CertificatePolicy, and ConfigurationPolicy should not have
a namespace set.

ref: https://issues.redhat.com/browse/ACM-7353
Signed-off-by: Dale Haiducek <[email protected]>

Author: dhaiducek

internal/ordering_test.go

@@ -657,7 +657,8 @@ policies:
   manifests:
   - path: {{printf "%v/%v" .Dir "configpolicy.yaml"}}
     extraDependencies:
-    - name: manifestextra
+    - kind: IamPolicy
+      name: manifestextra
   - path: {{printf "%v/%v" .Dir "configmap.yaml"}}
 - name: two
   manifests:

internal/plugin.go

@@ -783,21 +783,21 @@ func (p *Plugin) applyDefaults(unmarshaledConfig map[string]interface{}) {
 
 func applyDefaultDependencyFields(deps []types.PolicyDependency, namespace string) {
 	for i, dep := range deps {
-		if dep.Namespace == "" {
-			deps[i].Namespace = namespace
-		}
-
-		if dep.Compliance == "" {
-			deps[i].Compliance = "Compliant"
-		}
-
 		if dep.Kind == "" {
 			deps[i].Kind = policyKind
 		}
 
 		if dep.APIVersion == "" {
 			deps[i].APIVersion = policyAPIVersion
 		}
+
+		if dep.Namespace == "" && deps[i].Kind == policyKind {
+			deps[i].Namespace = namespace
+		}
+
+		if dep.Compliance == "" {
+			deps[i].Compliance = "Compliant"
+		}
 	}
 }
 

internal/testdata/ordering/manifest-extradeps-configpolicy.yaml

@@ -14,9 +14,8 @@ spec:
     - extraDependencies:
       - apiVersion: policy.open-cluster-management.io/v1
         compliance: Compliant
-        kind: Policy
+        kind: IamPolicy
         name: manifestextra
-        namespace: my-policies
       objectDefinition:
         apiVersion: policy.open-cluster-management.io/v1
         kind: ConfigurationPolicy